build: upgrade jasmine (and related typings) to latest version (#19904)
With these changes, the types are a little stricter now and also not
compatible with Protractor's jasmine-like syntax. So, we have to also
use `@types/jasminewd2` for e2e tests (but not for non-e2e tests).
I also had to "augment" `@types/jasminewd2`, because the latest
typings from [DefinitelyTyped][1] do not reflect the fact that the
`jasminewd2` version (v2.1.0) currently used by Protractor supports
passing a `done` callback to a spec.
[1]: 566e039485/types/jasminewd2/index.d.ts (L9-L15)
Fixes #23952
Closes #24733
PR Close #19904
This commit is contained in:

committed by
Miško Hevery

parent
1e74ea9e60
commit
00c110b055
@ -387,35 +387,35 @@ import {async_fit, async_it} from './async';
|
||||
});
|
||||
it('processes update availability notifications when sent', (done: DoneFn) => {
|
||||
update.available.subscribe(event => {
|
||||
expect(event.current).toEqual({version: 'A'});
|
||||
expect(event.available).toEqual({version: 'B'});
|
||||
expect(event.current).toEqual({hash: 'A'});
|
||||
expect(event.available).toEqual({hash: 'B'});
|
||||
expect(event.type).toEqual('UPDATE_AVAILABLE');
|
||||
done();
|
||||
});
|
||||
mock.sendMessage({
|
||||
type: 'UPDATE_AVAILABLE',
|
||||
current: {
|
||||
version: 'A',
|
||||
hash: 'A',
|
||||
},
|
||||
available: {
|
||||
version: 'B',
|
||||
hash: 'B',
|
||||
},
|
||||
});
|
||||
});
|
||||
it('processes update activation notifications when sent', (done: DoneFn) => {
|
||||
update.activated.subscribe(event => {
|
||||
expect(event.previous).toEqual({version: 'A'});
|
||||
expect(event.current).toEqual({version: 'B'});
|
||||
expect(event.previous).toEqual({hash: 'A'});
|
||||
expect(event.current).toEqual({hash: 'B'});
|
||||
expect(event.type).toEqual('UPDATE_ACTIVATED');
|
||||
done();
|
||||
});
|
||||
mock.sendMessage({
|
||||
type: 'UPDATE_ACTIVATED',
|
||||
previous: {
|
||||
version: 'A',
|
||||
hash: 'A',
|
||||
},
|
||||
current: {
|
||||
version: 'B',
|
||||
hash: 'B',
|
||||
},
|
||||
});
|
||||
});
|
||||
|
Reference in New Issue
Block a user