cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(ivy): DebugNode.classes not working on SVG elements (#34872)

Browse Source 
Fixes Ivy throwing an error when trying to access the `DebugNode.classes` of an SVG element. The problem is that the `className` of an SVG element is an `SVGAnimatedString`, rather than a plain string.

Fixes #34868.

PR Close #34872
This commit is contained in:
Kristiyan Kostadinov
2020-01-20 21:22:38 +01:00
committed by Andrew Kushnir
parent e1fc44f5d6
commit 00f13cc074
2 changed files with 23 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
packages/core/src/debug/debug_node.ts
View File

@ -352,10 +352,14 @@ class DebugElement__POST_R3__ extends DebugNode__POST_R3__ implements DebugEleme
get classes(): {[key: string]: boolean;} {
const result: {[key: string]: boolean;} = {};
const element = this.nativeElement as HTMLElement;
const classNames = element.className.split(' ');
const element = this.nativeElement as HTMLElement | SVGElement;
classNames.forEach((value: string) => result[value] = true);
// SVG elements return an `SVGAnimatedString` instead of a plain string for the `className`.
const className = element.className as string | SVGAnimatedString;
const classes = className && typeof className !== 'string' ? className.baseVal.split(' ') :
className.split(' ');
classes.forEach((value: string) => result[value] = true);
return result;
}