cargdev/angular
1
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(compiler): ensure compatibility with typescript strict flag (#30993)

Browse Source 
As part of FW-1265, the `@angular/compiler` package is made compatible
with the TypeScript `--strict` flag. This already unveiled a few bugs,
so the strictness flag seems to help with increasing the overall code health.

Read more about the strict flag [here](https://www.typescriptlang.org/docs/handbook/compiler-options.html)

PR Close #30993
This commit is contained in:
Paul Gschwendtner
2019-06-14 09:28:04 +02:00
committed by Miško Hevery
parent 2200884e55
commit 012b535147
11 changed files with 28 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/compiler/src/aot/static_reflector.ts
View File

@ -132,7 +132,7 @@ export class StaticReflector implements CompileReflector {
public tryAnnotations(type: StaticSymbol): any[] {
const originalRecorder = this.errorRecorder;
this.errorRecorder = (error: any, fileName: string) => {};
this.errorRecorder = (error: any, fileName?: string) => {};
try {
return this.annotations(type);
} finally {
@ -429,7 +429,7 @@ export class StaticReflector implements CompileReflector {
*/
private trySimplify(context: StaticSymbol, value: any): any {
const originalRecorder = this.errorRecorder;
this.errorRecorder = (error: any, fileName: string) => {};
this.errorRecorder = (error: any, fileName?: string) => {};
const result = this.simplify(context, value);
this.errorRecorder = originalRecorder;
return result;