cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(animations): make sure @.disabled works in non-animation components

Browse Source 
Note 4.3 only!

Prior to this fix when [@.disabled] was used in a component that
contained zero animation code it wouldn't register properly because the
renderer associated with that component was not an animation renderer.
This patch ensures that it gets registered even when there are no
animations set.
This commit is contained in:
Matias Niemelä
2017-07-11 15:41:12 -04:00
committed by Alex Rickabaugh
parent 8e56c3cb30
commit 01a2688848
3 changed files with 86 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
packages/animations/browser/src/render/animation_engine_next.ts
View File

@ -67,20 +67,17 @@ export class AnimationEngine {
this._transitionEngine.removeNode(namespaceId, element, context);
}
process(namespaceId: string, element: any, property: string, value: any): boolean {
switch (property.charAt(0)) {
case '.':
if (property == '.disabled') {
this._transitionEngine.markElementAsDisabled(element, !!value);
}
return false;
case '@':
const [id, action] = parseTimelineCommand(property);
const args = value as any[];
this._timelineEngine.command(id, element, action, args);
return false;
default:
return this._transitionEngine.trigger(namespaceId, element, property, value);
disableAnimations(element: any, disable: boolean) {
this._transitionEngine.markElementAsDisabled(element, disable);
}
process(namespaceId: string, element: any, property: string, value: any) {
if (property.charAt(0) == '@') {
const [id, action] = parseTimelineCommand(property);
const args = value as any[];
this._timelineEngine.command(id, element, action, args);
} else {
this._transitionEngine.trigger(namespaceId, element, property, value);
}
}