From 024126dde4ec100e9f1c121cf2b7208e88989191 Mon Sep 17 00:00:00 2001
From: Andrew Scott <atscott01@gmail.com>
Date: Sat, 27 Jun 2020 12:53:43 -0700
Subject: [PATCH] feat(dev-infra): add phased review to groups requiring final
 sign-off after initial review (#37798)

The size-tracking, public-api, and circular-dependencies groups can get a lot of
PRs to review. In addition, the members of these groups do not always
have the necessary context to fully review the PR in question. This
change ensures that the owners in the groups where the changes are being
made have approve the changes (ie, the aren't pending or rejected)
before requesting final sign-off from these three critical groups.

PR Close #37798
---
 .pullapprove.yml | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/.pullapprove.yml b/.pullapprove.yml
index 21659fa286..177d395ca5 100644
--- a/.pullapprove.yml
+++ b/.pullapprove.yml
@@ -1140,6 +1140,8 @@ groups:
   public-api:
     <<: *defaults
     conditions:
+      - *no-groups-above-this-pending
+      - *no-groups-above-this-rejected
       - *can-be-global-approved
       - >
         contains_any_globs(files, [
@@ -1170,6 +1172,8 @@ groups:
   size-tracking:
     <<: *defaults
     conditions:
+      - *no-groups-above-this-pending
+      - *no-groups-above-this-rejected
       - *can-be-global-approved
       - >
         contains_any_globs(files, [
@@ -1194,6 +1198,8 @@ groups:
   circular-dependencies:
     <<: *defaults
     conditions:
+      - *no-groups-above-this-pending
+      - *no-groups-above-this-rejected
       - *can-be-global-approved
       - >
         contains_any_globs(files, [