refactor(facade): Inline isBlank called with object-type argument (#11992)

modules/@angular/compiler/src/view_compiler/compile_element.ts

@@ -9,7 +9,7 @@
 
 import {CompileDiDependencyMetadata, CompileDirectiveMetadata, CompileIdentifierMetadata, CompileProviderMetadata, CompileQueryMetadata, CompileTokenMetadata} from '../compile_metadata';
 import {ListWrapper, MapWrapper, StringMapWrapper} from '../facade/collection';
-import {isBlank, isPresent} from '../facade/lang';
+import {isPresent} from '../facade/lang';
 import {Identifiers, identifierToken, resolveIdentifier, resolveIdentifierToken} from '../identifiers';
 import * as o from '../output/output_ast';
 import {convertValueToOutputAst} from '../output/value_util';
@@ -27,7 +27,7 @@ export class CompileNode {
       public parent: CompileElement, public view: CompileView, public nodeIndex: number,
       public renderNode: o.Expression, public sourceAst: TemplateAst) {}
 
-  isNull(): boolean { return isBlank(this.renderNode); }
+  isNull(): boolean { return !this.renderNode; }
 
   isRootElement(): boolean { return this.view != this.parent.view; }
 }
@@ -313,12 +313,12 @@ export class CompileElement extends CompileNode {
       requestingProviderType: ProviderAstType, dep: CompileDiDependencyMetadata): o.Expression {
     var result: o.Expression = null;
     // constructor content query
-    if (isBlank(result) && isPresent(dep.query)) {
+    if (!result && isPresent(dep.query)) {
       result = this._addQuery(dep.query, null).queryList;
     }
 
     // constructor view query
-    if (isBlank(result) && isPresent(dep.viewQuery)) {
+    if (!result && isPresent(dep.viewQuery)) {
       result = createQueryList(
           dep.viewQuery, null,
           `_viewQuery_${dep.viewQuery.selectors[0].name}_${this.nodeIndex}_${this._componentConstructorViewQueryLists.length}`,
@@ -328,7 +328,7 @@ export class CompileElement extends CompileNode {
 
     if (isPresent(dep.token)) {
       // access builtins with special visibility
-      if (isBlank(result)) {
+      if (!result) {
         if (dep.token.reference ===
             resolveIdentifierToken(Identifiers.ChangeDetectorRef).reference) {
           if (requestingProviderType === ProviderAstType.Component) {
@@ -339,7 +339,7 @@ export class CompileElement extends CompileNode {
         }
       }
       // access regular providers on the element
-      if (isBlank(result)) {
+      if (!result) {
         let resolvedProvider = this._resolvedProviders.get(dep.token.reference);
         // don't allow directives / public services to access private services.
         // only components and private services can access private services.
@@ -361,20 +361,20 @@ export class CompileElement extends CompileNode {
     if (dep.isValue) {
       result = o.literal(dep.value);
     }
-    if (isBlank(result) && !dep.isSkipSelf) {
+    if (!result && !dep.isSkipSelf) {
       result = this._getLocalDependency(requestingProviderType, dep);
     }
     // check parent elements
-    while (isBlank(result) && !currElement.parent.isNull()) {
+    while (!result && !currElement.parent.isNull()) {
       currElement = currElement.parent;
       result = currElement._getLocalDependency(
           ProviderAstType.PublicService, new CompileDiDependencyMetadata({token: dep.token}));
     }
 
-    if (isBlank(result)) {
+    if (!result) {
       result = injectFromViewParentInjector(dep.token, dep.isOptional);
     }
-    if (isBlank(result)) {
+    if (!result) {
       result = o.NULL_EXPR;
     }
     return getPropertyInView(result, this.view, currElement.view);
@@ -411,7 +411,7 @@ function createProviderProperty(
     resolvedProviderValueExpr = providerValueExpressions[0];
     type = providerValueExpressions[0].type;
   }
-  if (isBlank(type)) {
+  if (!type) {
     type = o.DYNAMIC_TYPE;
   }
   if (isEager) {

modules/@angular/compiler/src/view_compiler/compile_pipe.ts

@@ -8,7 +8,6 @@
 
 
 import {CompilePipeMetadata} from '../compile_metadata';
-import {isBlank} from '../facade/lang';
 import {Identifiers, resolveIdentifier, resolveIdentifierToken} from '../identifiers';
 import * as o from '../output/output_ast';
 
@@ -23,7 +22,7 @@ export class CompilePipe {
     if (meta.pure) {
       // pure pipes live on the component view
       pipe = compView.purePipes.get(name);
-      if (isBlank(pipe)) {
+      if (!pipe) {
         pipe = new CompilePipe(compView, meta);
         compView.purePipes.set(name, pipe);
         compView.pipes.push(pipe);
@@ -85,7 +84,7 @@ function _findPipeMeta(view: CompileView, name: string): CompilePipeMetadata {
       break;
     }
   }
-  if (isBlank(pipeMeta)) {
+  if (!pipeMeta) {
     throw new Error(
         `Illegal state: Could not find pipe ${name} although the parser should have detected this error!`);
   }

modules/@angular/compiler/src/view_compiler/compile_query.ts

@@ -8,7 +8,7 @@
 
 import {CompileQueryMetadata} from '../compile_metadata';
 import {ListWrapper} from '../facade/collection';
-import {isBlank, isPresent} from '../facade/lang';
+import {isPresent} from '../facade/lang';
 import {Identifiers, resolveIdentifier} from '../identifiers';
 import * as o from '../output/output_ast';
 
@@ -129,7 +129,7 @@ export function createQueryList(
 export function addQueryToTokenMap(map: Map<any, CompileQuery[]>, query: CompileQuery) {
   query.meta.selectors.forEach((selector) => {
     var entry = map.get(selector.reference);
-    if (isBlank(entry)) {
+    if (!entry) {
       entry = [];
       map.set(selector.reference, entry);
     }

modules/@angular/compiler/src/view_compiler/compile_view.ts

@@ -10,7 +10,7 @@ import {AnimationEntryCompileResult} from '../animation/animation_compiler';
 import {CompileDirectiveMetadata, CompileIdentifierMetadata, CompilePipeMetadata} from '../compile_metadata';
 import {CompilerConfig} from '../config';
 import {ListWrapper, MapWrapper} from '../facade/collection';
-import {isBlank, isPresent} from '../facade/lang';
+import {isPresent} from '../facade/lang';
 import {Identifiers, resolveIdentifier} from '../identifiers';
 import * as o from '../output/output_ast';
 import {ViewType} from '../private_import_core';
@@ -138,7 +138,7 @@ export class CompileView implements NameResolver {
     }
     var currView: CompileView = this;
     var result = currView.locals.get(name);
-    while (isBlank(result) && isPresent(currView.declarationElement.view)) {
+    while (!result && isPresent(currView.declarationElement.view)) {
       currView = currView.declarationElement.view;
       result = currView.locals.get(name);
     }

modules/@angular/compiler/src/view_compiler/event_binder.ts

@@ -8,7 +8,7 @@
 
 import {CompileDirectiveMetadata} from '../compile_metadata';
 import {StringMapWrapper} from '../facade/collection';
-import {StringWrapper, isBlank, isPresent} from '../facade/lang';
+import {StringWrapper, isPresent} from '../facade/lang';
 import {identifierToken} from '../identifiers';
 import * as o from '../output/output_ast';
 import {BoundEventAst, DirectiveAst} from '../template_parser/template_ast';
@@ -32,7 +32,7 @@ export class CompileEventListener {
     var listener = targetEventListeners.find(
         listener => listener.eventTarget == eventTarget && listener.eventName == eventName &&
             listener.eventPhase == eventPhase);
-    if (isBlank(listener)) {
+    if (!listener) {
       listener = new CompileEventListener(
           compileElement, eventTarget, eventName, eventPhase, targetEventListeners.length);
       targetEventListeners.push(listener);

modules/@angular/compiler/src/view_compiler/property_binder.ts

@@ -9,7 +9,7 @@
 import {SecurityContext} from '@angular/core';
 
 import * as cdAst from '../expression_parser/ast';
-import {isBlank, isPresent} from '../facade/lang';
+import {isPresent} from '../facade/lang';
 import {Identifiers, resolveIdentifier} from '../identifiers';
 import * as o from '../output/output_ast';
 import {EMPTY_STATE as EMPTY_ANIMATION_STATE, LifecycleHooks, isDefaultChangeDetectionStrategy} from '../private_import_core';
@@ -37,7 +37,7 @@ function bind(
     method: CompileMethod, bindingIndex: number) {
   var checkExpression = convertCdExpressionToIr(
       view, context, parsedExpression, DetectChangesVars.valUnwrapper, bindingIndex);
-  if (isBlank(checkExpression.expression)) {
+  if (!checkExpression.expression) {
     // e.g. an empty expression was given
     return;
   }

modules/@angular/compiler/src/view_compiler/util.ts

@@ -8,7 +8,7 @@
 
 
 import {CompileDirectiveMetadata, CompileTokenMetadata} from '../compile_metadata';
-import {isBlank, isPresent} from '../facade/lang';
+import {isPresent} from '../facade/lang';
 import {Identifiers, resolveIdentifier} from '../identifiers';
 import * as o from '../output/output_ast';
 import {createDiTokenExpression} from '../util';
@@ -84,7 +84,7 @@ export function createPureProxy(
   view.fields.push(new o.ClassField(pureProxyProp.name, null));
   var pureProxyId =
       argCount < Identifiers.pureProxies.length ? Identifiers.pureProxies[argCount] : null;
-  if (isBlank(pureProxyId)) {
+  if (!pureProxyId) {
     throw new Error(`Unsupported number of argument for pure functions: ${argCount}`);
   }
   view.createMethod.addStmt(o.THIS_EXPR.prop(pureProxyProp.name)