From 0341f3239af870d3fcbbe45316872c0c3c869757 Mon Sep 17 00:00:00 2001 From: Joey Perrott Date: Wed, 4 Dec 2019 12:05:53 -0800 Subject: [PATCH] build: set upper version limit for yarn to <2 (#34236) Rather than bumping up the allowed version of yarn on each release we should instead just allow for anything within the major version 1 range. PR Close #34236 --- aio/package.json | 4 ++-- aio/tools/examples/shared/package.json | 4 ++-- package.json | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/aio/package.json b/aio/package.json index 61ea002520..70e0f70e46 100644 --- a/aio/package.json +++ b/aio/package.json @@ -80,10 +80,10 @@ "post~~build": "yarn build-404-page", "~~light-server": "light-server --bind=localhost --historyindex=/index.html --no-reload" }, - "//engines-comment": "Keep this in sync with ../package.json", + "//engines-comment": "Keep this in sync with /package.json and /aio/tools/examples/shared/package.json", "engines": { "node": ">=10.9.0 <13.0.0", - "yarn": ">=1.17.3 <1.20.0" + "yarn": ">=1.17.3 <2" }, "private": true, "dependencies": { diff --git a/aio/tools/examples/shared/package.json b/aio/tools/examples/shared/package.json index 14ad2711d2..186ad400c3 100644 --- a/aio/tools/examples/shared/package.json +++ b/aio/tools/examples/shared/package.json @@ -10,10 +10,10 @@ "preinstall": "node ../../../../tools/yarn/check-yarn.js", "postinstall": "yarn webdriver:update" }, - "//engines-comment": "Keep this in sync with aio/package.json", + "//engines-comment": "Keep this in sync with /package.json and /aio/package.json", "engines": { "node": ">=10.9.0 <13.0.0", - "yarn": ">=1.17.3 <=1.19.1" + "yarn": ">=1.17.3 <2" }, "keywords": [], "author": "", diff --git a/package.json b/package.json index 5fc4368dea..2fe1dcd929 100644 --- a/package.json +++ b/package.json @@ -6,10 +6,10 @@ "homepage": "https://github.com/angular/angular", "bugs": "https://github.com/angular/angular/issues", "license": "MIT", - "//engines-comment": "Keep this in sync with aio/package.json", + "//engines-comment": "Keep this in sync with /aio/package.json and /aio/tools/examples/shared/package.json", "engines": { "node": ">=10.9.0 <13.0.0", - "yarn": ">=1.17.3 <1.20.0" + "yarn": ">=1.17.3 <2" }, "repository": { "type": "git",