cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: Consistently use index access on index signature types. (#28937)

Browse Source 
This change helps highlight certain misoptimizations with Closure
compiler. It is also stylistically preferable to consistently use index
access on index sig types.

Roughly, when one sees '.foo' they know it is always checked for typos
in the prop name by the type system (unless 'any'), while "['foo']" is
always not.

Once all angular repos are conforming this will become a tsetse.info
check, enforced by bazel.

PR Close #28937
This commit is contained in:
Rado Kirov
2019-02-22 14:30:10 -08:00
committed by Igor Minar
parent 2b974d4012
commit 03d2e5cb1d
7 changed files with 14 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
packages/compiler/src/aot/static_symbol_resolver.ts
View File

@ -420,18 +420,18 @@ export class StaticSymbolResolver {
if (!filePath) {
return {
__symbolic: 'error',
message:
`Could not resolve ${module} relative to ${self.host.getMetadataFor(sourceSymbol.filePath)}.`,
line: map.line,
character: map.character,
message: `Could not resolve ${module} relative to ${
self.host.getMetadataFor(sourceSymbol.filePath)}.`,
line: map['line'],
character: map['character'],
fileName: getOriginalName()
};
}
return {
__symbolic: 'resolved',
symbol: self.getStaticSymbol(filePath, name),
line: map.line,
character: map.character,
line: map['line'],
character: map['character'],
fileName: getOriginalName()
};
} else if (functionParams.indexOf(name) >= 0) {

2
packages/compiler/src/aot/summary_serializer.ts
View File

@ -249,7 +249,7 @@ class ToJsonSerializer extends ValueTransformer {
*/
visitStringMap(map: {[key: string]: any}, context: any): any {
if (map['__symbolic'] === 'resolved') {
return visitValue(map.symbol, this, context);
return visitValue(map['symbol'], this, context);
}
if (map['__symbolic'] === 'error') {
delete map['line'];