build: allow users to specify --strictNullChecks (#14382)

PR Close #14382

modules/@angular/core/src/core_private_export.ts

@@ -48,52 +48,68 @@ import * as viewEngine from './view/index';
 export const __core_private__: {
   isDefaultChangeDetectionStrategy: typeof constants.isDefaultChangeDetectionStrategy,
   ChangeDetectorStatus: typeof constants.ChangeDetectorStatus,
-  _ChangeDetectorStatus?: constants.ChangeDetectorStatus,
+  _ChangeDetectorStatus: constants.ChangeDetectorStatus,
   constructDependencies: typeof reflective_provider.constructDependencies,
   LifecycleHooks: typeof lifecycle_hooks.LifecycleHooks,
-  _LifecycleHooks?: lifecycle_hooks.LifecycleHooks,
+  _LifecycleHooks: lifecycle_hooks.LifecycleHooks,
   LIFECYCLE_HOOKS_VALUES: typeof lifecycle_hooks.LIFECYCLE_HOOKS_VALUES,
   ReflectorReader: typeof reflector_reader.ReflectorReader,
-  _ReflectorReader?: reflector_reader.ReflectorReader,
-  _SetterFn?: reflection_types.SetterFn;
-  _GetterFn?: reflection_types.GetterFn;
-  _MethodFn?: reflection_types.MethodFn;
+  _ReflectorReader: reflector_reader.ReflectorReader,
+  _SetterFn: reflection_types.SetterFn;
+  _GetterFn: reflection_types.GetterFn;
+  _MethodFn: reflection_types.MethodFn;
   CodegenComponentFactoryResolver:
       typeof component_factory_resolver.CodegenComponentFactoryResolver,
   ComponentRef_: typeof component_factory.ComponentRef_,
-  _CodegenComponentFactoryResolver?: component_factory_resolver.CodegenComponentFactoryResolver,
-  ViewContainer: typeof view_container.ViewContainer, _ViewContainer?: view_container.ViewContainer,
-  AppView: typeof view.AppView, _AppView?: view.AppView<any>,
-  DebugAppView: typeof view.DebugAppView, _DebugAppView?: view.DebugAppView<any>,
+  _CodegenComponentFactoryResolver: component_factory_resolver.CodegenComponentFactoryResolver,
+  ViewContainer: typeof view_container.ViewContainer,
+  _ViewContainer: view_container.ViewContainer,
+  AppView: typeof view.AppView,
+  _AppView: view.AppView<any>,
+  DebugAppView: typeof view.DebugAppView,
+  _DebugAppView: view.DebugAppView<any>,
   NgModuleInjector: typeof ng_module_factory.NgModuleInjector,
-  _NgModuleInjector?: ng_module_factory.NgModuleInjector<any>,
+  _NgModuleInjector: ng_module_factory.NgModuleInjector<any>,
   registerModuleFactory: typeof ng_module_factory_loader.registerModuleFactory,
-  ViewType: typeof view_type.ViewType, _ViewType?: view_type.ViewType,
-  ViewMetadata: typeof metadata_view.ViewMetadata, _ViewMetadata?: metadata_view.ViewMetadata,
-  DebugContext: typeof debug_context.DebugContext, _DebugContext?: debug_context.DebugContext,
+  ViewType: typeof view_type.ViewType,
+  _ViewType: view_type.ViewType,
+  ViewMetadata: typeof metadata_view.ViewMetadata,
+  _ViewMetadata: metadata_view.ViewMetadata,
+  DebugContext: typeof debug_context.DebugContext,
+  _DebugContext: debug_context.DebugContext,
   StaticNodeDebugInfo: typeof debug_context.StaticNodeDebugInfo,
-  _StaticNodeDebugInfo?: debug_context.StaticNodeDebugInfo,
+  _StaticNodeDebugInfo: debug_context.StaticNodeDebugInfo,
   devModeEqual: typeof change_detection_util.devModeEqual,
   ValueUnwrapper: typeof change_detection_util.ValueUnwrapper,
-  _ValueUnwrapper?: change_detection_util.ValueUnwrapper,
+  _ValueUnwrapper: change_detection_util.ValueUnwrapper,
   RenderDebugInfo: typeof api.RenderDebugInfo,
-  _RenderDebugInfo?: api.RenderDebugInfo,
-  _DirectRenderer?: api.DirectRenderer,
-  TemplateRef_: typeof template_ref.TemplateRef_, _TemplateRef_?: template_ref.TemplateRef_<any>,
+  _RenderDebugInfo: api.RenderDebugInfo,
+  _DirectRenderer: api.DirectRenderer,
+  TemplateRef_: typeof template_ref.TemplateRef_,
+  _TemplateRef_: template_ref.TemplateRef_<any>,
   ReflectionCapabilities: typeof reflection_capabilities.ReflectionCapabilities,
-  _ReflectionCapabilities?: reflection_capabilities.ReflectionCapabilities,
+  _ReflectionCapabilities: reflection_capabilities.ReflectionCapabilities,
   makeDecorator: typeof decorators.makeDecorator,
   DebugDomRootRenderer: typeof debug.DebugDomRootRenderer,
-  _DebugDomRootRenderer?: debug.DebugDomRootRenderer,
-  Console: typeof console.Console, _Console?: console.Console,
+  _DebugDomRootRenderer: debug.DebugDomRootRenderer,
+  Console: typeof console.Console,
+  _Console: console.Console,
   reflector: typeof reflection.reflector,
-  Reflector: typeof reflection.Reflector, _Reflector?: reflection.Reflector,
-  NoOpAnimationPlayer: typeof NoOpAnimationPlayer_, _NoOpAnimationPlayer?: NoOpAnimationPlayer_,
-  AnimationPlayer: typeof AnimationPlayer_, _AnimationPlayer?: AnimationPlayer_,
+  Reflector: typeof reflection.Reflector,
+  _Reflector: reflection.Reflector,
+  NoOpAnimationPlayer: typeof NoOpAnimationPlayer_,
+  _NoOpAnimationPlayer: NoOpAnimationPlayer_,
+  AnimationPlayer: typeof AnimationPlayer_,
+  _AnimationPlayer: AnimationPlayer_,
+
+
+
   AnimationSequencePlayer: typeof AnimationSequencePlayer_,
-  _AnimationSequencePlayer?: AnimationSequencePlayer_,
-  AnimationGroupPlayer: typeof AnimationGroupPlayer_, _AnimationGroupPlayer?: AnimationGroupPlayer_,
-  AnimationKeyframe: typeof AnimationKeyframe_, _AnimationKeyframe?: AnimationKeyframe_,
+  _AnimationSequencePlayer: AnimationSequencePlayer_,
+  AnimationGroupPlayer: typeof AnimationGroupPlayer_,
+  _AnimationGroupPlayer: AnimationGroupPlayer_,
+  AnimationKeyframe: typeof AnimationKeyframe_,
+  _AnimationKeyframe: AnimationKeyframe_,
   prepareFinalAnimationStyles: typeof animationUtils.prepareFinalAnimationStyles,
   balanceAnimationKeyframes: typeof animationUtils.balanceAnimationKeyframes,
   flattenStyles: typeof animationUtils.flattenStyles,
@@ -101,7 +117,8 @@ export const __core_private__: {
   renderStyles: typeof animationUtils.renderStyles,
   collectAndResolveStyles: typeof animationUtils.collectAndResolveStyles,
   APP_ID_RANDOM_PROVIDER: typeof application_tokens.APP_ID_RANDOM_PROVIDER,
-  AnimationStyles: typeof AnimationStyles_, _AnimationStyles?: AnimationStyles_,
+  AnimationStyles: typeof AnimationStyles_,
+  _AnimationStyles: AnimationStyles_,
   ANY_STATE: typeof ANY_STATE_,
   DEFAULT_STATE: typeof DEFAULT_STATE_,
   EMPTY_STATE: typeof EMPTY_STATE_,
@@ -111,11 +128,8 @@ export const __core_private__: {
   AnimationTransition: typeof AnimationTransition
   view_utils: typeof view_utils,
   ERROR_COMPONENT_TYPE: typeof ERROR_COMPONENT_TYPE,
-<<<<<<< HEAD
   viewEngine: typeof viewEngine,
-=======
   TransitionEngine: typeof TransitionEngine
->>>>>>> 4577b7c2a... refactor(animations): introduce @angular/animation module
 } = {
   isDefaultChangeDetectionStrategy: constants.isDefaultChangeDetectionStrategy,
   ChangeDetectorStatus: constants.ChangeDetectorStatus,
@@ -168,4 +182,4 @@ export const __core_private__: {
   AnimationTransition: AnimationTransition,
   ERROR_COMPONENT_TYPE: ERROR_COMPONENT_TYPE,
   TransitionEngine: TransitionEngine
-};
+} as any /* TODO(misko): export these using omega names instead */;

modules/@angular/core/src/util/decorators.ts

@@ -17,7 +17,7 @@ const Reflect = global.Reflect;
  *
  * @stable
  */
-export interface ClassDefinition {
+export type ClassDefinition = {
   /**
    * Optional argument for specifying the superclass.
    */
@@ -32,14 +32,15 @@ export interface ClassDefinition {
    *
    * See {@link Class} for example of usage.
    */
-  constructor: Function|any[];
-
+  constructor: Function | any[];
+} &
+{
   /**
    * Other methods on the class. Note that values should have type 'Function' but TS requires
    * all properties to have a narrower type than the index signature.
    */
   [x: string]: Type<any>|Function|any[];
-}
+};
 
 /**
  * An interface implemented by all Angular type decorators, which allows them to be used as ES7