From 04b12fc0d662c876f39d64088f021006cf99f3cc Mon Sep 17 00:00:00 2001 From: Pawel Kozlowski Date: Fri, 22 Nov 2019 16:33:05 +0100 Subject: [PATCH] refactor(ivy): remove isRootView check from getRenderParent (#33988) The root view case is already covered by the existing code in the getRenderParent function so no need to have an explicit checks (and associated memory reads) again. PR Close #33988 --- packages/core/src/render3/node_manipulation.ts | 7 +------ .../test/bundling/cyclic_import/bundle.golden_symbols.json | 3 --- .../test/bundling/hello_world/bundle.golden_symbols.json | 3 --- 3 files changed, 1 insertion(+), 12 deletions(-) diff --git a/packages/core/src/render3/node_manipulation.ts b/packages/core/src/render3/node_manipulation.ts index 8a901ffb98..1f22e6da4f 100644 --- a/packages/core/src/render3/node_manipulation.ts +++ b/packages/core/src/render3/node_manipulation.ts @@ -17,7 +17,7 @@ import {NodeInjectorFactory} from './interfaces/injector'; import {TElementNode, TNode, TNodeFlags, TNodeType, TProjectionNode, TViewNode, unusedValueExportToPlacateAjd as unused2} from './interfaces/node'; import {unusedValueExportToPlacateAjd as unused3} from './interfaces/projection'; import {ProceduralRenderer3, RElement, RNode, RText, Renderer3, isProceduralRenderer, unusedValueExportToPlacateAjd as unused4} from './interfaces/renderer'; -import {isLContainer, isLView, isRootView} from './interfaces/type_checks'; +import {isLContainer, isLView} from './interfaces/type_checks'; import {CHILD_HEAD, CLEANUP, DECLARATION_COMPONENT_VIEW, DECLARATION_LCONTAINER, FLAGS, HOST, HookData, LView, LViewFlags, NEXT, PARENT, QUERIES, RENDERER, TVIEW, T_HOST, unusedValueExportToPlacateAjd as unused5} from './interfaces/view'; import {assertNodeOfPossibleTypes, assertNodeType} from './node_assert'; import {getLViewParent} from './util/view_traversal_utils'; @@ -503,11 +503,6 @@ function executeOnDestroys(view: LView): void { * into destination. */ function getRenderParent(tNode: TNode, currentView: LView): RElement|null { - // Nodes of the top-most view can be inserted eagerly. - if (isRootView(currentView)) { - return nativeParentNode(currentView[RENDERER], getNativeByTNode(tNode, currentView)); - } - // Skip over element and ICU containers as those are represented by a comment node and // can't be used as a render parent. let parentTNode = tNode.parent; diff --git a/packages/core/test/bundling/cyclic_import/bundle.golden_symbols.json b/packages/core/test/bundling/cyclic_import/bundle.golden_symbols.json index a1d6182a2e..5fad4cad3b 100644 --- a/packages/core/test/bundling/cyclic_import/bundle.golden_symbols.json +++ b/packages/core/test/bundling/cyclic_import/bundle.golden_symbols.json @@ -497,9 +497,6 @@ { "name": "isProceduralRenderer" }, - { - "name": "isRootView" - }, { "name": "isStylingContext" }, diff --git a/packages/core/test/bundling/hello_world/bundle.golden_symbols.json b/packages/core/test/bundling/hello_world/bundle.golden_symbols.json index c950037e12..1f6c456c07 100644 --- a/packages/core/test/bundling/hello_world/bundle.golden_symbols.json +++ b/packages/core/test/bundling/hello_world/bundle.golden_symbols.json @@ -365,9 +365,6 @@ { "name": "isProceduralRenderer" }, - { - "name": "isRootView" - }, { "name": "leaveDI" },