cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(AppViewListener): prefix listener with on for consistency

Browse Source 
Closes #3925
This commit is contained in:
Victor Berchet
2015-08-31 16:47:50 -07:00
parent 608cdc4077
commit 04b4035ecd
4 changed files with 15 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
modules/angular2/src/core/debug/debug_element_view_listener.ts
View File

@ -50,7 +50,7 @@ export class DebugElementViewListener implements AppViewListener {
DOM.setGlobalVar(INSPECT_GLOBAL_NAME, inspectNativeElement);
}
viewCreated(view: AppView) {
onViewCreated(view: AppView) {
var viewId = _nextId++;
_allViewsById.set(viewId, view);
_allIdsByView.set(view, viewId);
@ -60,7 +60,7 @@ export class DebugElementViewListener implements AppViewListener {
}
}
viewDestroyed(view: AppView) {
onViewDestroyed(view: AppView) {
var viewId = _allIdsByView.get(view);
_allIdsByView.delete(view);
_allViewsById.delete(viewId);

4
modules/angular2/src/core/linker/view_listener.ts
View File

@ -6,6 +6,6 @@ import * as viewModule from './view';
*/
@Injectable()
export class AppViewListener {
viewCreated(view: viewModule.AppView) {}
viewDestroyed(view: viewModule.AppView) {}
onViewCreated(view: viewModule.AppView) {}
onViewDestroyed(view: viewModule.AppView) {}
}

6
modules/angular2/src/core/linker/view_manager.ts
View File

@ -251,7 +251,7 @@ export class AppViewManager_ extends AppViewManager {
this._renderer.detachFragment(hostView.renderFragment);
this._renderer.dehydrateView(hostView.render);
this._viewDehydrateRecurse(hostView);
this._viewListener.viewDestroyed(hostView);
this._viewListener.onViewDestroyed(hostView);
this._renderer.destroyView(hostView.render);
wtfLeave(s);
}
@ -390,7 +390,7 @@ export class AppViewManager_ extends AppViewManager {
var mergedParentView =
this._utils.createView(protoView, renderViewWithFragments, this, this._renderer);
this._renderer.setEventDispatcher(mergedParentView.render, mergedParentView);
this._viewListener.viewCreated(mergedParentView);
this._viewListener.onViewCreated(mergedParentView);
return mergedParentView;
}
@ -409,7 +409,7 @@ export class AppViewManager_ extends AppViewManager {
_destroyPooledView(view: viewModule.AppView) {
var wasReturned = this._viewPool.returnView(view);
if (!wasReturned) {
this._viewListener.viewDestroyed(view);
this._viewListener.onViewDestroyed(view);
this._renderer.destroyView(view.render);
}
}