cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

revert: feat(router): better warning message when a router outlet has not been instantiated (#38920)

Browse Source 
This reverts commit [1609815].
The warning that was added created more confusion than it solved and also warned for valid use-cases.

PR Close #38920
This commit is contained in:
Marley Powell 2020-09-21 13:34:39 +01:00 committed by Misko Hevery
parent 7d5b5153cf
commit 04d0aa6781
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/router/src/operators/activate_routes.ts
View File

@ -186,10 +186,6 @@ export class ActivateRoutes {
// Activate the outlet when it has already been instantiated // Activate the outlet when it has already been instantiated
// Otherwise it will get activated from its `ngOnInit` when instantiated // Otherwise it will get activated from its `ngOnInit` when instantiated
context.outlet.activateWith(future, cmpFactoryResolver); context.outlet.activateWith(future, cmpFactoryResolver);
} else if (isDevMode() && console && console.warn) {
console.warn(
`A router outlet has not been instantiated during routes activation. URL Segment: '${
future.snapshot._urlSegment}'`);
} }
this.activateChildRoutes(futureNode, null, context.children); this.activateChildRoutes(futureNode, null, context.children);