cargdev/angular
1
0
Fork 0
Code Issues 5 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(core): don’t throw if queries change during change detection.

Browse Source 
Throwing on query changes would be a breaking change compared to v2.
Also discovers a bug with querying manually projected content, see #15117.

Related to #14748
Closes #14925
This commit is contained in:
Tobias Bosch
2017-03-13 11:12:13 -07:00
committed by Chuck Jazdzewski
parent 959a03a61f
commit 06fc42bc44
3 changed files with 25 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
packages/core/src/view/view.ts
View File

@ -318,12 +318,10 @@ function createViewNodes(view: ViewData) {
export function checkNoChangesView(view: ViewData) {
Services.updateDirectives(view, CheckType.CheckNoChanges);
execEmbeddedViewsAction(view, ViewAction.CheckNoChanges);
execQueriesAction(
view, NodeFlags.TypeContentQuery, NodeFlags.DynamicQuery, CheckType.CheckNoChanges);
Services.updateRenderer(view, CheckType.CheckNoChanges);
execComponentViewsAction(view, ViewAction.CheckNoChanges);
execQueriesAction(
view, NodeFlags.TypeViewQuery, NodeFlags.DynamicQuery, CheckType.CheckNoChanges);
// Note: We don't check queries for changes as we didn't do this in v2.x.
// TODO(tbosch): investigate if we can enable the check again in v5.x with a nicer error message.
}
export function checkAndUpdateView(view: ViewData) {