cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(Dart1.8): fix analyzer warnings

Browse Source
This commit is contained in:
Victor Berchet 2014-12-01 19:19:07 +01:00
parent 3e57189e45
commit 0703ee526c
4 changed files with 5 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
modules/change_detection/src/parser/lexer.js
View File

@ -385,7 +385,6 @@ class _Scanner {
var last:string = input.substring(marker, this.index); var last:string = input.substring(marker, this.index);
this.advance(); // Skip terminating quote. this.advance(); // Skip terminating quote.
var str:string = input.substring(start, this.index);
// Compute the unescaped string value. // Compute the unescaped string value.
var unescaped:string = last; var unescaped:string = last;

2
modules/core/test/compiler/compiler_spec.js
View File

@ -17,7 +17,7 @@ import {Lexer} from 'change_detection/parser/lexer';
export function main() { export function main() {
describe('compiler', function() { describe('compiler', function() {
var compiler, reader; var reader;
beforeEach( () => { beforeEach( () => {
reader = new DirectiveMetadataReader(); reader = new DirectiveMetadataReader();

7
modules/core/test/compiler/pipeline/pipeline_spec.js
View File

@ -10,13 +10,6 @@ import {CompileControl} from 'core/compiler/pipeline/compile_control';
export function main() { export function main() {
describe('compile_pipeline', () => { describe('compile_pipeline', () => {
var logs, pipeline, loggingStep;
beforeEach( () => {
logs = [];
loggingStep = new LoggingStep(logs);
});
it('should walk the tree in depth first order including template contents', () => { it('should walk the tree in depth first order including template contents', () => {
var element = createElement('<div id="1"><template id="2"><span id="3"></span></template></div>'); var element = createElement('<div id="1"><template id="2"><span id="3"></span></template></div>');

8
modules/core/test/compiler/view_spec.js
View File

@ -171,7 +171,7 @@ export function main() {
}); });
describe('recurse over child component views', () => { describe('recurse over child component views', () => {
var view, ctx; var ctx;
function createComponentWithSubPV(subProtoView) { function createComponentWithSubPV(subProtoView) {
var pv = new ProtoView(createElement('<cmp class="ng-binding"></cmp>'), new ProtoRecordRange()); var pv = new ProtoView(createElement('<cmp class="ng-binding"></cmp>'), new ProtoRecordRange());
@ -209,7 +209,7 @@ export function main() {
() => { () => {
var subpv = new ProtoView( var subpv = new ProtoView(
createElement('<div dec class="ng-binding">hello shadow dom</div>'), new ProtoRecordRange()); createElement('<div dec class="ng-binding">hello shadow dom</div>'), new ProtoRecordRange());
var subBinder = subpv.bindElement( subpv.bindElement(
new ProtoElementInjector(null, 0, [ServiceDependentDecorator])); new ProtoElementInjector(null, 0, [ServiceDependentDecorator]));
var pv = createComponentWithSubPV(subpv); var pv = createComponentWithSubPV(subpv);
@ -227,7 +227,7 @@ export function main() {
}); });
describe('recurse over child templateViews', () => { describe('recurse over child templateViews', () => {
var ctx, view, cd; var ctx, view;
function createView(protoView) { function createView(protoView) {
ctx = new MyEvaluationContext(); ctx = new MyEvaluationContext();
view = protoView.instantiate(ctx, null, null); view = protoView.instantiate(ctx, null, null);
@ -310,7 +310,7 @@ export function main() {
it('should inject the protoView into the shadowDom', () => { it('should inject the protoView into the shadowDom', () => {
var rootProtoView = ProtoView.createRootProtoView(pv, el, someComponentDirective); var rootProtoView = ProtoView.createRootProtoView(pv, el, someComponentDirective);
var view = rootProtoView.instantiate(null, new Injector([]), null, true); rootProtoView.instantiate(null, new Injector([]), null, true);
expect(el.shadowRoot.childNodes[0].childNodes[0].nodeValue).toEqual('hi'); expect(el.shadowRoot.childNodes[0].childNodes[0].nodeValue).toEqual('hi');
}); });
}); });