cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(ivy): improve bindV perf and memory usage (#21881)

Browse Source 
- Fix the case when first dynamic values are NO_CHANGE
- Do not store the static texts (even indexes) as bindings,
- Do not diff static texts (they do not change),
- Do not stringify static texts,
- Remove superfluous values walking.

PR Close #21881
This commit is contained in:
Victor Berchet 2018-01-30 16:33:28 -08:00 committed by Alex Rickabaugh
parent 0d10b9002e
commit 0846784b98
1 changed files with 22 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
packages/core/src/render3/instructions.ts
View File

@ -1372,33 +1372,38 @@ export const NO_CHANGE = {} as NO_CHANGE;
* If any of the arguments change, then the interpolation is concatenated * If any of the arguments change, then the interpolation is concatenated
* and causes an update. * and causes an update.
* *
* @param values an array of values to diff. * `values`:
* - has static text at even indexes,
* - has evaluated expressions at odd indexes (could be NO_CHANGE).
*/ */
export function bindV(values: any[]): string|NO_CHANGE { export function bindV(values: any[]): string|NO_CHANGE {
ngDevMode && assertLessThan(2, values.length, 'should have at least 3 values');
ngDevMode && assertEqual(values.length % 2, 1, 'should have an odd number of values');
// TODO(vicb): Add proper unit tests when there is a place to add them
if (creationMode) { if (creationMode) {
initBindings(); initBindings();
data[bindingIndex++] = values.slice(); // Only the bindings (odd indexes) are stored as texts are constant.
const bindings: any[] = [];
data[bindingIndex++] = bindings;
let content: string = values[0]; let content: string = values[0];
for (let i = 1; i < values.length; i++) { for (let i = 1; i < values.length; i += 2) {
content += stringify(values[i]); content += stringify(values[i]) + values[i + 1];
bindings.push(values[i]);
} }
return content; return content;
} }
const parts: any[] = data[bindingIndex++]; const bindings: any[] = data[bindingIndex++];
for (let i = 0; i < values.length; i++) { // `bIdx` is the index in the `bindings` array, `vIdx` in the `values` array
if (values[i] !== NO_CHANGE && isDifferent(values[i], parts[i])) { for (let bIdx = 0, vIdx = 1; bIdx < bindings.length; bIdx++, vIdx += 2) {
let content = ''; if (values[vIdx] !== NO_CHANGE && isDifferent(values[vIdx], bindings[bIdx])) {
// The i first values are the same, no need to update the bindings let content: string = values[0];
for (let j = 0; j < i; j++) { for (bIdx = 0, vIdx = 1; bIdx < bindings.length; vIdx += 2, bIdx++) {
content += stringify(parts[j]); if (values[vIdx] !== NO_CHANGE) {
} bindings[bIdx] = values[vIdx];
// The subsequent values might have changed, update the bindings
for (let j = i; j < values.length; j++) {
if (values[j] !== NO_CHANGE) {
parts[j] = values[j];
} }
content += stringify(parts[j]); content += stringify(bindings[bIdx]) + values[vIdx + 1];
} }
return content; return content;
} }