cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(language-service): remove repeated symbol definitions for structural directive (#34847)

Browse Source 
For the structural directive, the 'path' will contain multiple `BoundDirectivePropertyAst` which depends on the number of directive property in the attribute value(e.g. '*ngFor="let item of []; trackBy: test;"', it has 2 `BoundDirectivePropertyAst`, 'ngForOf' and 'ngForTrackBy').

PR Close #34847
This commit is contained in:
ivanwonder
2020-01-26 22:48:11 +08:00
committed by Andrew Kushnir
parent e7dff9eb0c
commit 09869af90f
2 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/language-service/test/definitions_spec.ts
View File

@ -311,7 +311,7 @@ describe('definitions', () => {
expect(definitions).toBeDefined();
// The two definitions are setter and getter of 'ngForTrackBy'.
expect(definitions !.length).toBe(4);
expect(definitions !.length).toBe(2);
const refFileName = '/node_modules/@angular/common/common.d.ts';
definitions !.forEach(def => {
@ -335,7 +335,7 @@ describe('definitions', () => {
expect(textSpan).toEqual(marker);
expect(definitions).toBeDefined();
expect(definitions !.length).toBe(2);
expect(definitions !.length).toBe(1);
const refFileName = '/app/parsing-cases.ts';
const def = definitions ![0];