cargdev/angular
1
0
Fork 0
Code Issues 6 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(core): static-query schematic should detect queries in "ngDoCheck" and "ngOnChanges" (#29492)

Browse Source 
Queries can be also used statically within the "ngDoCheck" and "ngOnChanges" lifecylce hook.
In order to properly detect all queries, we need to also respect these lifecycle hooks.

Resolves FW-1192

PR Close #29492
This commit is contained in:
Paul Gschwendtner
2019-03-23 21:12:53 +01:00
committed by Misko Hevery
parent b3102b9de1
commit 09fab58109
2 changed files with 43 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
packages/core/schematics/test/static_queries_migration_spec.ts
View File

@ -161,6 +161,26 @@ describe('static-queries migration', () => {
.toContain(`@${queryType}('dynamic', { static: false }) dynamic: any`);
});
it('should mark queries used in "ngOnChanges" as static', () => {
writeFile('/index.ts', `
import {Component, ${queryType}} from '@angular/core';
@Component({template: '<span #test></span>'})
export class MyComp {
@${queryType}('test') query: any;
ngOnChanges() {
this.query.classList.add('test');
}
}
`);
runMigration();
expect(tree.readContent('/index.ts'))
.toContain(`@${queryType}('test', { static: true }) query: any;`);
});
it('should mark queries used in "ngOnInit" as static', () => {
writeFile('/index.ts', `
import {Component, ${queryType}} from '@angular/core';
@ -181,6 +201,26 @@ describe('static-queries migration', () => {
.toContain(`@${queryType}('test', { static: true }) query: any;`);
});
it('should mark queries used in "ngDoCheck" as static', () => {
writeFile('/index.ts', `
import {Component, ${queryType}} from '@angular/core';
@Component({template: '<span #test></span>'})
export class MyComp {
@${queryType}('test') query: any;
ngDoCheck() {
this.query.classList.add('test');
}
}
`);
runMigration();
expect(tree.readContent('/index.ts'))
.toContain(`@${queryType}('test', { static: true }) query: any;`);
});
it('should keep existing query options when updating timing', () => {
writeFile('/index.ts', `
import {Component, ${queryType}} from '@angular/core';