cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(compiler): avoid a crash in ngc-wrapped. (#23468)

Browse Source 
`ng.performCompilation` can return an `undefined` program, which is not handled by ngc-wrapped.

Avoid crashing by checking for the error return and returning the diagnostics.
PR Close #23468
This commit is contained in:
Martin Probst 2018-04-20 14:53:32 +02:00 committed by Victor Berchet
parent db17231597
commit 0bc8443e12
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/bazel/src/ngc-wrapped/index.ts
View File

@ -268,6 +268,10 @@ export function compile({allowNonHermeticReads, allDepsCompiledWithBazel = true,
} }
} }
// If compilation fails unexpectedly, performCompilation returns no program.
// Make sure not to crash but report the diagnostics.
if (!program) return {program, diagnostics};
if (!bazelOpts.nodeModulesPrefix) { if (!bazelOpts.nodeModulesPrefix) {
// If there is no node modules, then metadata.json should be emitted since // If there is no node modules, then metadata.json should be emitted since
// there is no other way to obtain the information // there is no other way to obtain the information