cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(service-worker): check platformBrowser before accessing navigator.serviceWorker (#21231)

Browse Source 
PR Close #21231
This commit is contained in:
Heo Sangmin
2018-05-10 00:11:43 +09:00
committed by Matias Niemelä
parent 373fa78d7f
commit 0bdd30e34f
4 changed files with 99 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
packages/service-worker/src/low_level.ts
View File

@ -6,8 +6,6 @@
* found in the LICENSE file at https://angular.io/license
*/
import {isPlatformBrowser} from '@angular/common';
import {Inject, PLATFORM_ID} from '@angular/core';
import {ConnectableObservable, Observable, concat, defer, fromEvent, of , throwError} from 'rxjs';
import {filter, map, publish, switchMap, take, tap} from 'rxjs/operators';
@ -71,11 +69,8 @@ export class NgswCommChannel {
*/
readonly events: Observable<TypedEvent>;
constructor(
private serviceWorker: ServiceWorkerContainer|undefined,
@Inject(PLATFORM_ID) platformId: string) {
if (!serviceWorker || !isPlatformBrowser(platformId)) {
this.serviceWorker = undefined;
constructor(private serviceWorker: ServiceWorkerContainer|undefined) {
if (!serviceWorker) {
this.worker = this.events = this.registration = errorObservable(ERR_SW_NOT_SUPPORTED);
} else {
const controllerChangeEvents =