test(language-service): wrap setup() in beforeAll to speed up fit() test (#39305)

Test harness `setup()` is expensive, in the order of ~2.5 seconds.

We could speed up `fit()` tests considerably if `setup()` is wrapped
in `beforeAll()` to avoid running it unnecessarily.

PR Close #39305

packages/language-service/ivy/test/compiler_factory_spec.ts

@@ -6,9 +6,9 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {APP_COMPONENT, setup, TEST_TEMPLATE} from './mock_host';
+import * as ts from 'typescript/lib/tsserverlibrary';
 
-const {project, service} = setup();
+import {APP_COMPONENT, MockService, setup, TEST_TEMPLATE} from './mock_host';
 
 /**
  * The following specs do not directly test the CompilerFactory class, rather
@@ -17,6 +17,15 @@ const {project, service} = setup();
  */
 
 describe('tsserver', () => {
+  let project: ts.server.Project;
+  let service: MockService;
+
+  beforeAll(() => {
+    const {project: _project, service: _service} = setup();
+    project = _project;
+    service = _service;
+  });
+
   beforeEach(() => {
     service.reset();
   });

packages/language-service/ivy/test/definitions_spec.ts

@@ -6,16 +6,20 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import * as ts from 'typescript/lib/tsserverlibrary';
-
 import {LanguageService} from '../language_service';
 
-import {APP_COMPONENT, setup} from './mock_host';
+import {APP_COMPONENT, MockService, setup} from './mock_host';
 import {humanizeDefinitionInfo} from './test_utils';
 
 describe('definitions', () => {
-  const {project, service, tsLS} = setup();
+  let service: MockService;
-  const ngLS = new LanguageService(project, tsLS);
+  let ngLS: LanguageService;
+
+  beforeAll(() => {
+    const {project, service: _service, tsLS} = setup();
+    service = _service;
+    ngLS = new LanguageService(project, tsLS);
+  });
 
   beforeEach(() => {
     service.reset();

packages/language-service/ivy/test/diagnostic_spec.ts

@@ -10,11 +10,17 @@ import * as ts from 'typescript/lib/tsserverlibrary';
 
 import {LanguageService} from '../language_service';
 
-import {APP_COMPONENT, setup, TEST_TEMPLATE} from './mock_host';
+import {APP_COMPONENT, MockService, setup, TEST_TEMPLATE} from './mock_host';
 
 describe('getSemanticDiagnostics', () => {
-  const {project, service, tsLS} = setup();
+  let service: MockService;
-  const ngLS = new LanguageService(project, tsLS);
+  let ngLS: LanguageService;
+
+  beforeAll(() => {
+    const {project, service: _service, tsLS} = setup();
+    service = _service;
+    ngLS = new LanguageService(project, tsLS);
+  });
 
   beforeEach(() => {
     service.reset();

packages/language-service/ivy/test/language_service_adapter_spec.ts

@@ -6,12 +6,22 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {LanguageServiceAdapter} from '../language_service_adapter';
+import * as ts from 'typescript/lib/tsserverlibrary';
-import {setup, TEST_TEMPLATE} from './mock_host';
 
-const {project, service} = setup();
+import {LanguageServiceAdapter} from '../language_service_adapter';
+
+import {MockService, setup, TEST_TEMPLATE} from './mock_host';
 
 describe('Language service adapter', () => {
+  let project: ts.server.Project;
+  let service: MockService;
+
+  beforeAll(() => {
+    const {project: _project, service: _service} = setup();
+    project = _project;
+    service = _service;
+  });
+
   it('should mark template dirty if it has not seen the template before', () => {
     const adapter = new LanguageServiceAdapter(project);
     expect(adapter.isTemplateDirty(TEST_TEMPLATE)).toBeTrue();

packages/language-service/ivy/test/language_service_spec.ts

@@ -6,11 +6,23 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
+import * as ts from 'typescript/lib/tsserverlibrary';
+
 import {LanguageService, parseNgCompilerOptions} from '../language_service';
 
-import {setup, TEST_TEMPLATE} from './mock_host';
+import {MockService, setup, TEST_TEMPLATE} from './mock_host';
 
-const {project, tsLS, service} = setup();
+describe('language service adapter', () => {
+  let project: ts.server.Project;
+  let service: MockService;
+  let ngLS: LanguageService;
+
+  beforeAll(() => {
+    const {project: _project, tsLS, service: _service} = setup();
+    project = _project;
+    service = _service;
+    ngLS = new LanguageService(project, tsLS);
+  });
 
   describe('parseNgCompilerOptions', () => {
     it('should read angularCompilerOptions in tsconfig.json', () => {
@@ -24,8 +36,6 @@ describe('parseNgCompilerOptions', () => {
   });
 
   describe('last known program', () => {
-  const ngLS = new LanguageService(project, tsLS);
-
     beforeEach(() => {
       service.reset();
     });
@@ -104,6 +114,7 @@ describe('last known program', () => {
       expect(p2).not.toBe(p1);  // last known program should have changed
     });
   });
+});
 
 function getLastKnownProgram(ngLS: LanguageService): ts.Program {
   const program = ngLS['compilerFactory']['lastKnownProgram'];

packages/language-service/ivy/test/mock_host_spec.ts

@@ -8,10 +8,19 @@
 
 import * as ts from 'typescript/lib/tsserverlibrary';
 
-import {APP_COMPONENT, APP_MAIN, setup, TEST_SRCDIR} from './mock_host';
+import {APP_COMPONENT, APP_MAIN, MockService, setup, TEST_SRCDIR} from './mock_host';
 
 describe('mock host', () => {
-  const {project, service, tsLS} = setup();
+  let service: MockService;
+  let project: ts.server.Project;
+  let tsLS: ts.LanguageService;
+
+  beforeAll(() => {
+    const {project: _project, service: _service, tsLS: _tsLS} = setup();
+    project = _project;
+    service = _service;
+    tsLS = _tsLS;
+  });
 
   beforeEach(() => {
     service.reset();

packages/language-service/ivy/test/quick_info_spec.ts

@@ -10,11 +10,17 @@ import * as ts from 'typescript/lib/tsserverlibrary';
 
 import {LanguageService} from '../language_service';
 
-import {APP_COMPONENT, setup, TEST_TEMPLATE} from './mock_host';
+import {APP_COMPONENT, MockService, setup, TEST_TEMPLATE} from './mock_host';
 
 describe('quick info', () => {
-  const {project, service, tsLS} = setup();
+  let service: MockService;
-  const ngLS = new LanguageService(project, tsLS);
+  let ngLS: LanguageService;
+
+  beforeAll(() => {
+    const {project, service: _service, tsLS} = setup();
+    service = _service;
+    ngLS = new LanguageService(project, tsLS);
+  });
 
   beforeEach(() => {
     service.reset();

packages/language-service/ivy/test/type_definitions_spec.ts

@@ -8,12 +8,19 @@
 
 import {LanguageService} from '../language_service';
 
-import {APP_COMPONENT, setup} from './mock_host';
+import {APP_COMPONENT, MockService, setup} from './mock_host';
 import {HumanizedDefinitionInfo, humanizeDefinitionInfo} from './test_utils';
 
 describe('type definitions', () => {
-  const {project, service, tsLS} = setup();
+  let service: MockService;
-  const ngLS = new LanguageService(project, tsLS);
+  let ngLS: LanguageService;
+
+  beforeAll(() => {
+    const {project, service: _service, tsLS} = setup();
+    service = _service;
+    ngLS = new LanguageService(project, tsLS);
+  });
+
   const possibleArrayDefFiles = new Set([
     'lib.es5.d.ts', 'lib.es2015.core.d.ts', 'lib.es2015.iterable.d.ts',
     'lib.es2015.symbol.wellknown.d.ts', 'lib.es2016.array.include.d.ts'