cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(core): remove readonly getters in common, compiler (#19150)

Browse Source 
PR Close #19150
This commit is contained in:
Yuan Gao
2017-09-11 15:10:19 -07:00
committed by Matias Niemelä
parent 996c7c2dde
commit 0c44e733ad
6 changed files with 56 additions and 52 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
packages/compiler/src/template_parser/binding_parser.ts
View File

@ -36,13 +36,15 @@ export enum BoundPropertyType {
* Represents a parsed property.
*/
export class BoundProperty {
public readonly isLiteral: boolean;
public readonly isAnimation: boolean;
constructor(
public name: string, public expression: ASTWithSource, public type: BoundPropertyType,
public sourceSpan: ParseSourceSpan) {}
get isLiteral() { return this.type === BoundPropertyType.LITERAL_ATTR; }
get isAnimation() { return this.type === BoundPropertyType.ANIMATION; }
public sourceSpan: ParseSourceSpan) {
this.isLiteral = this.type === BoundPropertyType.LITERAL_ATTR;
this.isAnimation = this.type === BoundPropertyType.ANIMATION;
}
}
/**

17
packages/compiler/src/template_parser/template_ast.ts
View File

@ -63,14 +63,17 @@ export class AttrAst implements TemplateAst {
* `[@trigger]="stateExp"`)
*/
export class BoundElementPropertyAst implements TemplateAst {
public readonly isAnimation: boolean;
constructor(
public name: string, public type: PropertyBindingType,
public securityContext: SecurityContext, public value: AST, public unit: string|null,
public sourceSpan: ParseSourceSpan) {}
public sourceSpan: ParseSourceSpan) {
this.isAnimation = this.type === PropertyBindingType.Animation;
}
visit(visitor: TemplateAstVisitor, context: any): any {
return visitor.visitElementProperty(this, context);
}
get isAnimation(): boolean { return this.type === PropertyBindingType.Animation; }
}
/**
@ -88,14 +91,18 @@ export class BoundEventAst implements TemplateAst {
}
}
public readonly fullName: string;
public readonly isAnimation: boolean;
constructor(
public name: string, public target: string|null, public phase: string|null,
public handler: AST, public sourceSpan: ParseSourceSpan) {}
public handler: AST, public sourceSpan: ParseSourceSpan) {
this.fullName = BoundEventAst.calcFullName(this.name, this.target, this.phase);
this.isAnimation = !!this.phase;
}
visit(visitor: TemplateAstVisitor, context: any): any {
return visitor.visitEvent(this, context);
}
get fullName() { return BoundEventAst.calcFullName(this.name, this.target, this.phase); }
get isAnimation(): boolean { return !!this.phase; }
}
/**