cargdev/angular
1
0
Fork 0
Code Issues 4 Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(ngcc): remove unused EntryPointProcessingMetadata data and types (#32427)

Browse Source 
Previously, `ngcc` needed to store some metadata related to the
processing of each entry-point. This metadata was stored in a `Map`, in
the form of `EntryPointProcessingMetadata` and passed around as needed.

After some recent refactorings, it turns out that this metadata (with
its only remaining property, `hasProcessedTypings`) was no longer used,
because the relevant information was extracted from other sources (such
as the `processDts` property on `Task`s).

This commit cleans up the code by removing the unused code and types.

PR Close #32427
This commit is contained in:
George Kalpakas
2019-08-29 15:28:00 +03:00
committed by Matias Niemelä
parent 9270d3f279
commit 0cf94e3ed5
4 changed files with 15 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
packages/compiler-cli/ngcc/src/execution/utils.ts
View File

@ -11,14 +11,12 @@ import {markAsProcessed} from '../packages/build_marker';
import {PackageJsonFormatProperties} from '../packages/entry_point';
import {PackageJsonUpdater} from '../writing/package_json_updater';
import {EntryPointProcessingMetadata, Task, TaskProcessingOutcome} from './api';
import {Task, TaskProcessingOutcome} from './api';
/** A helper function for handling a task's being completed. */
export const onTaskCompleted =
(pkgJsonUpdater: PackageJsonUpdater,
processingMetadataPerEntryPoint: Map<string, EntryPointProcessingMetadata>, task: Task,
outcome: TaskProcessingOutcome, ): void => {
(pkgJsonUpdater: PackageJsonUpdater, task: Task, outcome: TaskProcessingOutcome): void => {
const {entryPoint, formatPropertiesToMarkAsProcessed, processDts} = task;
if (outcome === TaskProcessingOutcome.Processed) {
@ -27,8 +25,6 @@ export const onTaskCompleted =
[...formatPropertiesToMarkAsProcessed];
if (processDts) {
const processingMeta = processingMetadataPerEntryPoint.get(entryPoint.path) !;
processingMeta.hasProcessedTypings = true;
propsToMarkAsProcessed.push('typings');
}