From 0f21ae9a743a15f35f9873a50ee77aca8b5ea336 Mon Sep 17 00:00:00 2001 From: George Kalpakas Date: Thu, 3 Oct 2019 19:28:56 +0300 Subject: [PATCH] docs(core): mark `EventEmitter#__isAsync` as internal to hide from API docs (#31378) The `__isAsync` property is not part of the public API and should not appear in the API docs. PR Close #31378 --- packages/core/src/event_emitter.ts | 6 +----- tools/public_api_guard/core/core.d.ts | 1 - 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/packages/core/src/event_emitter.ts b/packages/core/src/event_emitter.ts index e7b255072b..07143d9774 100644 --- a/packages/core/src/event_emitter.ts +++ b/packages/core/src/event_emitter.ts @@ -62,12 +62,8 @@ import {Subject, Subscription} from 'rxjs'; * @publicApi */ export class EventEmitter extends Subject { - // TODO: mark this as internal once all the facades are gone - // we can't mark it as internal now because EventEmitter exported via @angular/core would not - // contain this property making it incompatible with all the code that uses EventEmitter via - // facades, which are local to the code and do not have this property stripped. /** - * Internal + * @internal */ __isAsync: boolean; // tslint:disable-line diff --git a/tools/public_api_guard/core/core.d.ts b/tools/public_api_guard/core/core.d.ts index 70919a41bc..4bb2faacd3 100644 --- a/tools/public_api_guard/core/core.d.ts +++ b/tools/public_api_guard/core/core.d.ts @@ -326,7 +326,6 @@ export declare class ErrorHandler { } export declare class EventEmitter extends Subject { - __isAsync: boolean; constructor(isAsync?: boolean); emit(value?: T): void; subscribe(generatorOrNext?: any, error?: any, complete?: any): Subscription;