cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(dart/transform): Remove unnecessary getter/setter codegen

Browse Source 
Currently the transformer generates all getters and setters even when
creating pre-generated change detectors, which remove the need for them.

Generate getters and setters via the model provided by `ProtoViewDto`,
which contains enough information to allow omitting unnecessary getters
and setters from code output.

Allow generating getters, setters, and method names which are Dart
pseudo keywords.

Closes #3489
This commit is contained in:
Tim Blasi
2015-08-07 11:54:43 -07:00
parent ba2c077b01
commit 104302a958
26 changed files with 791 additions and 106 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
modules/angular2/src/change_detection/parser/parser.ts
View File

@ -490,14 +490,11 @@ export class _ParseAST {
new MethodCall(receiver, id, fn, args);
} else {
let getter = this.reflector.getter(id);
let setter = this.reflector.setter(id);
if (isSafe) {
if (this.optionalOperator("=")) {
this.error("The '?.' operator cannot be used in the assignment");
} else {
return new SafePropertyRead(receiver, id, getter);
return new SafePropertyRead(receiver, id, this.reflector.getter(id));
}
} else {
if (this.optionalOperator("=")) {
@ -506,9 +503,9 @@ export class _ParseAST {
}
let value = this.parseConditional();
return new PropertyWrite(receiver, id, setter, value);
return new PropertyWrite(receiver, id, this.reflector.setter(id), value);
} else {
return new PropertyRead(receiver, id, getter);
return new PropertyRead(receiver, id, this.reflector.getter(id));
}
}
}