From 1084d4ab49f67ac8d93d857a703478e355efefc1 Mon Sep 17 00:00:00 2001
From: Martin Probst <martin@probst.io>
Date: Wed, 4 Dec 2019 16:59:05 +0100
Subject: [PATCH] refactor(upgrade): avoid mutable exports. (#34232)

Previously, create_angular_testing_module would export a mutable `let`
binding. The binding is already exporting using an accessor function
though, so the export on the let variable seems like an accidental
oversight.

This is functionally equivalent, but makes it easier for module
optimizers such as Closure Compiler to track down side effects and prune
modules.

PR Close #34232
---
 .../upgrade/static/testing/src/create_angular_testing_module.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/upgrade/static/testing/src/create_angular_testing_module.ts b/packages/upgrade/static/testing/src/create_angular_testing_module.ts
index bbaa2f5c8f..b3db0d102d 100644
--- a/packages/upgrade/static/testing/src/create_angular_testing_module.ts
+++ b/packages/upgrade/static/testing/src/create_angular_testing_module.ts
@@ -12,7 +12,7 @@ import * as angular from '../../../src/common/src/angular1';
 import {$INJECTOR, INJECTOR_KEY, UPGRADE_APP_TYPE_KEY} from '../../../src/common/src/constants';
 import {UpgradeAppType} from '../../../src/common/src/util';
 
-export let $injector: angular.IInjectorService|null = null;
+let $injector: angular.IInjectorService|null = null;
 let injector: Injector;
 
 export function $injectorFactory() {