cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(forms): make Validators.email support optional controls (#20869)

Browse Source 
Bring email validator in line with other validators so that empty values are ignored.

PR Close #20869
This commit is contained in:
Phil McCloghry-Laing
2017-12-07 17:24:49 +11:00
committed by Miško Hevery
parent 941e88ff79
commit 140e7c00d1
3 changed files with 16 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
packages/forms/test/validators_spec.ts
View File

@ -159,6 +159,12 @@ import {map} from 'rxjs/operator/map';
});
describe('email', () => {
it('should not error on an empty string',
() => expect(Validators.email(new FormControl(''))).toBeNull());
it('should not error on null',
() => expect(Validators.email(new FormControl(null))).toBeNull());
it('should error on invalid email',
() => expect(Validators.email(new FormControl('some text'))).toEqual({'email': true}));