cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

build: re-enable template type-checking for various targets across the repo (#34144)

Browse Source 
Various targets have their template type-checking disabled in the past.

There is no reason for this any more.

The only target that was tricky was packages/examples/core:core_examples
which was quite broken and I had to fix it up.

Template typechecking is still disabled under blaze, see FW-1753 for more
info.

PR Close #34144
This commit is contained in:
Igor Minar
2019-11-29 01:54:33 -08:00
committed by Miško Hevery
parent d8792b3c36
commit 1421eff382
38 changed files with 14 additions and 79 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
modules/benchmarks/src/largeform/ng2/BUILD.bazel
View File

@ -9,11 +9,7 @@ ng_module(
name = "ng2",
srcs = glob(["*.ts"]),
generate_ve_shims = True,
# FIXME-IVY(FW-998): ExpressionTranslatorVisitor#visitWriteKeyExpr is not implemented.
tags = ["fixme-ivy-aot"],
tsconfig = "//modules/benchmarks:tsconfig-build.json",
# TODO: FW-1004 Type checking is currently not complete.
type_check = False,
deps = [
"//modules/benchmarks/src:util_lib",
"//packages/core",
@ -36,13 +32,11 @@ ts_devserver(
"//tools/rxjs:rxjs_umd_modules",
],
static_files = ["index.html"],
tags = ["fixme-ivy-aot"],
deps = [":ng2"],
)
benchmark_test(
name = "perf",
server = ":devserver",
tags = ["fixme-ivy-aot"],
deps = ["//modules/benchmarks/src/largeform:tests_lib"],
)

2
modules/benchmarks/src/largetable/ng2/BUILD.bazel
View File

@ -11,8 +11,6 @@ ng_module(
srcs = glob(["*.ts"]),
generate_ve_shims = True,
tsconfig = "//modules/benchmarks:tsconfig-build.json",
# TODO: FW-1004 Type checking is currently not complete.
type_check = False,
deps = [
"//modules/benchmarks/src:util_lib",
"//modules/benchmarks/src/largetable:util_lib",

2
modules/benchmarks/src/largetable/ng2_switch/BUILD.bazel
View File

@ -8,8 +8,6 @@ ng_module(
srcs = glob(["*.ts"]),
generate_ve_shims = True,
tsconfig = "//modules/benchmarks:tsconfig-build.json",
# TODO: FW-1004 Type checking is currently not complete.
type_check = False,
deps = [
"//modules/benchmarks/src:util_lib",
"//modules/benchmarks/src/largetable:util_lib",

2
modules/benchmarks/src/tree/ng2/BUILD.bazel
View File

@ -11,8 +11,6 @@ ng_module(
srcs = glob(["*.ts"]),
generate_ve_shims = True,
tsconfig = "//modules/benchmarks:tsconfig-build.json",
# TODO: FW-1004 Type checking is currently not complete.
type_check = False,
deps = [
"//modules/benchmarks/src:util_lib",
"//modules/benchmarks/src/tree:util_lib",

2
modules/benchmarks/src/tree/ng2_switch/BUILD.bazel
View File

@ -8,8 +8,6 @@ ng_module(
srcs = glob(["*.ts"]),
generate_ve_shims = True,
tsconfig = "//modules/benchmarks:tsconfig-build.json",
# TODO: FW-1004 Type checking is currently not complete.
type_check = False,
deps = [
"//modules/benchmarks/src:util_lib",
"//modules/benchmarks/src/tree:util_lib",