cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test(upgrade): re-enable tests fixed in ivy (#27454)

Browse Source 
PR Close #27454
This commit is contained in:
Pete Bacon Darwin 2018-12-04 10:55:03 +00:00 committed by Igor Minar
parent 130ae158c4
commit 145121a75d
5 changed files with 418 additions and 428 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
packages/upgrade/test/common/downgrade_component_adapter_spec.ts
View File

@ -7,7 +7,6 @@
*/ */
import {Compiler, Component, ComponentFactory, Injector, NgModule, TestabilityRegistry} from '@angular/core'; import {Compiler, Component, ComponentFactory, Injector, NgModule, TestabilityRegistry} from '@angular/core';
import {TestBed} from '@angular/core/testing'; import {TestBed} from '@angular/core/testing';
import {fixmeIvy} from '@angular/private/testing';
import * as angular from '@angular/upgrade/src/common/angular1'; import * as angular from '@angular/upgrade/src/common/angular1';
import {DowngradeComponentAdapter, groupNodesBySelector} from '@angular/upgrade/src/common/downgrade_component_adapter'; import {DowngradeComponentAdapter, groupNodesBySelector} from '@angular/upgrade/src/common/downgrade_component_adapter';

3
packages/upgrade/test/dynamic/upgrade_spec.ts
View File

@ -1681,7 +1681,6 @@ withEachNg1Version(() => {
}); });
})); }));
fixmeIvy('unknown') &&
it('should not call `$onInit()` on scope', async(() => { it('should not call `$onInit()` on scope', async(() => {
const adapter: UpgradeAdapter = new UpgradeAdapter(forwardRef(() => Ng2Module)); const adapter: UpgradeAdapter = new UpgradeAdapter(forwardRef(() => Ng2Module));
const $onInitSpy = jasmine.createSpy('$onInit'); const $onInitSpy = jasmine.createSpy('$onInit');
@ -1783,7 +1782,6 @@ withEachNg1Version(() => {
}); });
})); }));
fixmeIvy('unknown') &&
it('should not call `$doCheck()` on scope', async(() => { it('should not call `$doCheck()` on scope', async(() => {
const adapter: UpgradeAdapter = new UpgradeAdapter(forwardRef(() => Ng2Module)); const adapter: UpgradeAdapter = new UpgradeAdapter(forwardRef(() => Ng2Module));
const $doCheckSpyA = jasmine.createSpy('$doCheckA'); const $doCheckSpyA = jasmine.createSpy('$doCheckA');
@ -1885,7 +1883,6 @@ withEachNg1Version(() => {
}); });
})); }));
fixmeIvy('unknown') &&
it('should not call `$postLink()` on scope', async(() => { it('should not call `$postLink()` on scope', async(() => {
const adapter: UpgradeAdapter = new UpgradeAdapter(forwardRef(() => Ng2Module)); const adapter: UpgradeAdapter = new UpgradeAdapter(forwardRef(() => Ng2Module));
const $postLinkSpy = jasmine.createSpy('$postLink'); const $postLinkSpy = jasmine.createSpy('$postLink');

4
packages/upgrade/test/static/integration/downgrade_component_spec.ts
View File

@ -520,7 +520,6 @@ withEachNg1Version(() => {
}); });
})); }));
fixmeIvy('FW-713: ngDestroy not being called when downgraded ng2 component is destroyed') &&
it('should properly run cleanup when ng1 directive is destroyed', async(() => { it('should properly run cleanup when ng1 directive is destroyed', async(() => {
let destroyed = false; let destroyed = false;
@ -559,7 +558,6 @@ withEachNg1Version(() => {
}); });
})); }));
fixmeIvy('FW-642: ASSERTION ERROR: Slot should have been initialized to NO_CHANGE') &&
it('should properly run cleanup with multiple levels of nesting', async(() => { it('should properly run cleanup with multiple levels of nesting', async(() => {
let destroyed = false; let destroyed = false;
@ -743,7 +741,7 @@ withEachNg1Version(() => {
}); });
})); }));
fixmeIvy('FW-561: Runtime compiler is not loaded') && fixmeIvy('FW-717: Browser locks up and disconnects') &&
it('should work with ng2 lazy loaded components', async(() => { it('should work with ng2 lazy loaded components', async(() => {
let componentInjector: Injector; let componentInjector: Injector;

2
packages/upgrade/test/static/integration/downgrade_module_spec.ts
View File

@ -225,7 +225,6 @@ withEachNg1Version(() => {
}); });
})); }));
fixmeIvy('FW-713: ngDestroy not being called when downgraded ng2 component is destroyed') &&
it('should destroy components inside the Angular zone', async(() => { it('should destroy components inside the Angular zone', async(() => {
let destroyedInTheZone = false; let destroyedInTheZone = false;
@ -526,7 +525,6 @@ withEachNg1Version(() => {
}); });
})); }));
fixmeIvy('FW-717: Browser locks up and disconnects') &&
it('should detach hostViews from the ApplicationRef once destroyed', async(() => { it('should detach hostViews from the ApplicationRef once destroyed', async(() => {
let ng2Component: Ng2Component; let ng2Component: Ng2Component;

4
packages/upgrade/test/static/integration/upgrade_component_spec.ts
View File

@ -3965,7 +3965,6 @@ withEachNg1Version(() => {
}); });
})); }));
fixmeIvy('FW-642: ASSERTION ERROR: Slot should have been initialized to NO_CHANGE') &&
it('should support ng2 > ng1 > ng2 (with inputs/outputs)', fakeAsync(() => { it('should support ng2 > ng1 > ng2 (with inputs/outputs)', fakeAsync(() => {
let ng2ComponentAInstance: Ng2ComponentA; let ng2ComponentAInstance: Ng2ComponentA;
let ng2ComponentBInstance: Ng2ComponentB; let ng2ComponentBInstance: Ng2ComponentB;
@ -4050,8 +4049,7 @@ withEachNg1Version(() => {
} }
// Define `ng1Module` // Define `ng1Module`
const ng1Module = const ng1Module = angular.module('ng1', [])
angular.module('ng1', [])
.component('ng1X', ng1Component) .component('ng1X', ng1Component)
.directive('ng2A', downgradeComponent({component: Ng2ComponentA})) .directive('ng2A', downgradeComponent({component: Ng2ComponentA}))
.directive('ng2B', downgradeComponent({component: Ng2ComponentB})); .directive('ng2B', downgradeComponent({component: Ng2ComponentB}));