chore: fix DDC errors / warnings

Closes #7195

modules/benchpress/test/metric/perflog_metric_spec.ts

@@ -39,7 +39,7 @@ export function main() {
                           captureFrames?: boolean,
                           receivedData?: boolean,
                           requestCount?: boolean
-                        } = {}) {
+                        } = {}): Metric {
     commandLog = [];
     if (isBlank(perfLogFeatures)) {
       perfLogFeatures =
@@ -384,7 +384,7 @@ export function main() {
                  aggregate(
                      [eventFactory.instant('frame', 4), eventFactory.markEnd('frameCapture', 5)],
                      {captureFrames: true}),
-                 (err) => {
+                 (err): any => {
                    expect(() => { throw err; })
                        .toThrowError('missing start event for frame capture');
                    async.done();
@@ -396,7 +396,7 @@ export function main() {
                  aggregate(
                      [eventFactory.markStart('frameCapture', 3), eventFactory.instant('frame', 4)],
                      {captureFrames: true}),
-                 (err) => {
+                 (err): any => {
                    expect(() => { throw err; }).toThrowError('missing end event for frame capture');
                    async.done();
                  });
@@ -410,7 +410,7 @@ export function main() {
                        eventFactory.markStart('frameCapture', 4)
                      ],
                      {captureFrames: true}),
-                 (err) => {
+                 (err): any => {
                    expect(() => { throw err; })
                        .toThrowError('can capture frames only once per benchmark run');
                    async.done();
@@ -424,12 +424,13 @@ export function main() {
                    .toThrowError(
                        'found start event for frame capture, but frame capture was not requested in benchpress');
                async.done();
+               return null;
              });
            }));
 
         it('should throw if frame capture is enabled, but nothing is captured',
            inject([AsyncTestCompleter], (async) => {
-             PromiseWrapper.catchError(aggregate([], {captureFrames: true}), (err) => {
+             PromiseWrapper.catchError(aggregate([], {captureFrames: true}), (err): any => {
                expect(() => { throw err; })
                    .toThrowError(
                        'frame capture requested in benchpress, but no start event was found');

modules/benchpress/test/runner_spec.ts

@@ -31,7 +31,7 @@ export function main() {
     var injector: Injector;
     var runner;
 
-    function createRunner(defaultBindings = null) {
+    function createRunner(defaultBindings = null): Runner {
       if (isBlank(defaultBindings)) {
         defaultBindings = [];
       }

modules/benchpress/test/sampler_spec.ts

@@ -31,7 +31,7 @@ export function main() {
   var EMPTY_EXECUTE = () => {};
 
   describe('sampler', () => {
-    var sampler;
+    var sampler: Sampler;
 
     function createSampler({driver, metric, reporter, validator, prepare, execute}: {
       driver?: any,

modules/benchpress/test/webdriver/chrome_driver_extension_spec.ts

@@ -49,7 +49,7 @@ export function main() {
     var normEvents = new TraceEventFactory('timeline', 'pid0');
 
     function createExtension(perfRecords = null, userAgent = null,
-                             messageMethod = 'Tracing.dataCollected') {
+                             messageMethod = 'Tracing.dataCollected'): WebDriverExtension {
       if (isBlank(perfRecords)) {
         perfRecords = [];
       }
@@ -85,7 +85,7 @@ export function main() {
 
     it('should mark the timeline via console.timeEnd()', inject([AsyncTestCompleter], (async) => {
          createExtension()
-             .timeEnd('someName')
+             .timeEnd('someName', null)
              .then((_) => {
                expect(log).toEqual([['executeScript', `console.timeEnd('someName');`]]);
                async.done();
@@ -467,7 +467,7 @@ export function main() {
                    benchmarkEvents.instant('BenchmarkInstrumentation::ImplThreadRenderingStats',
                                            1100, {'data': {'frame_count': 2}})
                  ]).readPerfLog(),
-                 (err) => {
+                 (err): any => {
                    expect(() => { throw err; })
                        .toThrowError('multi-frame render stats not supported');
                    async.done();
@@ -502,7 +502,7 @@ export function main() {
                    ],
                    CHROME45_USER_AGENT, 'Tracing.bufferUsage')
                    .readPerfLog(),
-               (err) => {
+               (err): any => {
                  expect(() => { throw err; })
                      .toThrowError('The DevTools trace buffer filled during the test!');
                  async.done();

modules/benchpress/test/webdriver/ios_driver_extension_spec.ts

@@ -32,7 +32,7 @@ export function main() {
 
     var normEvents = new TraceEventFactory('timeline', 'pid0');
 
-    function createExtension(perfRecords = null) {
+    function createExtension(perfRecords = null): WebDriverExtension {
       if (isBlank(perfRecords)) {
         perfRecords = [];
       }
@@ -61,7 +61,7 @@ export function main() {
 
     it('should mark the timeline via console.timeEnd()', inject([AsyncTestCompleter], (async) => {
          createExtension()
-             .timeEnd('someName')
+             .timeEnd('someName', null)
              .then((_) => {
                expect(log).toEqual([['executeScript', `console.timeEnd('someName');`]]);
                async.done();