chore: fix DDC errors / warnings

Closes #7195

tools/public_api_guard/public_api_spec.ts

@@ -382,7 +382,7 @@ const CORE = [
   'Reflector.isReflectionEnabled():boolean',
   'Reflector.listUnusedKeys():any[]',
   'Reflector.method(name:string):MethodFn',
-  'Reflector.parameters(typeOrFunc:any):any[]',
+  'Reflector.parameters(typeOrFunc:any):any[][]',
   'Reflector.propMetadata(typeOrFunc:any):{[key:string]:any[]}',
   'Reflector.reflectionCapabilities:PlatformReflectionCapabilities',
   'Reflector.registerFunction(func:Function, funcInfo:ReflectionInfo):void',
@@ -555,7 +555,7 @@ const CORE = [
 
 const COMMON = [
   'AbstractControl',
-  'AbstractControl.constructor(validator:Function, asyncValidator:Function)',
+  'AbstractControl.constructor(validator:ValidatorFn, asyncValidator:AsyncValidatorFn)',
   'AbstractControl.dirty:boolean',
   'AbstractControl.errors:{[key:string]:any}',
   'AbstractControl.find(path:Array<string|number>|string):AbstractControl',
@@ -599,12 +599,12 @@ const COMMON = [
   'CheckboxControlValueAccessor.registerOnTouched(fn:() => {}):void',
   'CheckboxControlValueAccessor.writeValue(value:any):void',
   'Control',
-  'Control.constructor(value:any, validator:Function, asyncValidator:Function)',
+  'Control.constructor(value:any, validator:ValidatorFn, asyncValidator:AsyncValidatorFn)',
   'Control.registerOnChange(fn:Function):void',
   'Control.updateValue(value:any, {onlySelf,emitEvent,emitModelToViewChange}:{onlySelf?:boolean, emitEvent?:boolean, emitModelToViewChange?:boolean}):void',
   'ControlArray',
   'ControlArray.at(index:number):AbstractControl',
-  'ControlArray.constructor(controls:AbstractControl[], validator:Function, asyncValidator:Function)',
+  'ControlArray.constructor(controls:AbstractControl[], validator:ValidatorFn, asyncValidator:AsyncValidatorFn)',
   'ControlArray.insert(index:number, control:AbstractControl):void',
   'ControlArray.length:number',
   'ControlArray.push(control:AbstractControl):void',
@@ -615,7 +615,7 @@ const COMMON = [
   'ControlContainer.path:string[]',
   'ControlGroup',
   'ControlGroup.addControl(name:string, control:AbstractControl):void',
-  'ControlGroup.constructor(controls:{[key:string]:AbstractControl}, optionals:{[key:string]:boolean}, validator:Function, asyncValidator:Function)',
+  'ControlGroup.constructor(controls:{[key:string]:AbstractControl}, optionals:{[key:string]:boolean}, validator:ValidatorFn, asyncValidator:AsyncValidatorFn)',
   'ControlGroup.contains(controlName:string):boolean',
   'ControlGroup.exclude(controlName:string):void',
   'ControlGroup.include(controlName:string):void',
@@ -647,8 +647,8 @@ const COMMON = [
   'Form.removeControlGroup(dir:NgControlGroup):void',
   'Form.updateModel(dir:NgControl, value:any):void',
   'FormBuilder',
-  'FormBuilder.array(controlsConfig:any[], validator:Function, asyncValidator:Function):ControlArray',
-  'FormBuilder.control(value:Object, validator:Function, asyncValidator:Function):Control',
+  'FormBuilder.array(controlsConfig:any[], validator:ValidatorFn, asyncValidator:AsyncValidatorFn):ControlArray',
+  'FormBuilder.control(value:Object, validator:ValidatorFn, asyncValidator:AsyncValidatorFn):Control',
   'FormBuilder.group(controlsConfig:{[key:string]:any}, extra:{[key:string]:any}):ControlGroup',
   'I18nPluralPipe',
   'I18nPluralPipe.transform(value:number, args:any[]):string',
@@ -660,10 +660,10 @@ const COMMON = [
   'LowerCasePipe.transform(value:string, args:any[]):string',
   'MaxLengthValidator',
   'MaxLengthValidator.constructor(maxLength:string)',
-  'MaxLengthValidator.validate(c:Control):{[key:string]:any}',
+  'MaxLengthValidator.validate(c:AbstractControl):{[key:string]:any}',
   'MinLengthValidator',
   'MinLengthValidator.constructor(minLength:string)',
-  'MinLengthValidator.validate(c:Control):{[key:string]:any}',
+  'MinLengthValidator.validate(c:AbstractControl):{[key:string]:any}',
   'NgClass',
   'NgClass.constructor(_iterableDiffers:IterableDiffers, _keyValueDiffers:KeyValueDiffers, _ngEl:ElementRef, _renderer:Renderer)',
   'NgClass.initialClasses=(v:string)',
@@ -671,22 +671,22 @@ const COMMON = [
   'NgClass.ngOnDestroy():void',
   'NgClass.rawClass=(v:string|string[]|Set<string>|{[key:string]:any})',
   'NgControl',
-  'NgControl.asyncValidator:Function',
+  'NgControl.asyncValidator:AsyncValidatorFn',
   'NgControl.name:string',
-  'NgControl.validator:Function',
+  'NgControl.validator:ValidatorFn',
   'NgControl.valueAccessor:ControlValueAccessor',
   'NgControl.viewToModelUpdate(newValue:any):void',
   'NgControlGroup',
-  'NgControlGroup.asyncValidator:Function',
+  'NgControlGroup.asyncValidator:AsyncValidatorFn',
   'NgControlGroup.constructor(parent:ControlContainer, _validators:any[], _asyncValidators:any[])',
   'NgControlGroup.control:ControlGroup',
   'NgControlGroup.formDirective:Form',
   'NgControlGroup.ngOnDestroy():void',
   'NgControlGroup.ngOnInit():void',
   'NgControlGroup.path:string[]',
-  'NgControlGroup.validator:Function',
+  'NgControlGroup.validator:ValidatorFn',
   'NgControlName',
-  'NgControlName.asyncValidator:Function',
+  'NgControlName.asyncValidator:AsyncValidatorFn',
   'NgControlName.constructor(_parent:ControlContainer, _validators:any[], _asyncValidators:any[], valueAccessors:ControlValueAccessor[])',
   'NgControlName.control:Control',
   'NgControlName.formDirective:any',
@@ -695,7 +695,7 @@ const COMMON = [
   'NgControlName.ngOnDestroy():void',
   'NgControlName.path:string[]',
   'NgControlName.update:any',
-  'NgControlName.validator:Function',
+  'NgControlName.validator:ValidatorFn',
   'NgControlName.viewModel:any',
   'NgControlName.viewToModelUpdate(newValue:any):void',
   'NgControlStatus',
@@ -729,7 +729,7 @@ const COMMON = [
   'NgForm.removeControlGroup(dir:NgControlGroup):void',
   'NgForm.updateModel(dir:NgControl, value:any):void',
   'NgFormControl',
-  'NgFormControl.asyncValidator:Function',
+  'NgFormControl.asyncValidator:AsyncValidatorFn',
   'NgFormControl.constructor(_validators:any[], _asyncValidators:any[], valueAccessors:ControlValueAccessor[])',
   'NgFormControl.control:Control',
   'NgFormControl.form:Control',
@@ -737,7 +737,7 @@ const COMMON = [
   'NgFormControl.ngOnChanges(changes:{[key:string]:SimpleChange}):void',
   'NgFormControl.path:string[]',
   'NgFormControl.update:any',
-  'NgFormControl.validator:Function',
+  'NgFormControl.validator:ValidatorFn',
   'NgFormControl.viewModel:any',
   'NgFormControl.viewToModelUpdate(newValue:any):void',
   'NgFormModel',
@@ -761,14 +761,14 @@ const COMMON = [
   'NgIf.constructor(_viewContainer:ViewContainerRef, _templateRef:TemplateRef)',
   'NgIf.ngIf=(newCondition:any)',
   'NgModel',
-  'NgModel.asyncValidator:Function',
+  'NgModel.asyncValidator:AsyncValidatorFn',
   'NgModel.constructor(_validators:any[], _asyncValidators:any[], valueAccessors:ControlValueAccessor[])',
   'NgModel.control:Control',
   'NgModel.model:any',
   'NgModel.ngOnChanges(changes:{[key:string]:SimpleChange}):any',
   'NgModel.path:string[]',
   'NgModel.update:any',
-  'NgModel.validator:Function',
+  'NgModel.validator:ValidatorFn',
   'NgModel.viewModel:any',
   'NgModel.viewToModelUpdate(newValue:any):void',
   'NgSelectOption',
@@ -786,7 +786,7 @@ const COMMON = [
   'NumberPipe',
   'PatternValidator',
   'PatternValidator.constructor(pattern:string)',
-  'PatternValidator.validate(c:Control):{[key:string]:any}',
+  'PatternValidator.validate(c:AbstractControl):{[key:string]:any}',
   'PercentPipe',
   'PercentPipe.transform(value:any, args:any[]):string',
   'ReplacePipe',
@@ -805,15 +805,15 @@ const COMMON = [
   'UpperCasePipe',
   'UpperCasePipe.transform(value:string, args:any[]):string',
   'Validator',
-  'Validator.validate(c:Control):{[key:string]:any}',
+  'Validator.validate(c:AbstractControl):{[key:string]:any}',
   'Validators',
-  'Validators.compose(validators:Function[]):Function',
-  'Validators.composeAsync(validators:Function[]):Function',
-  'Validators.maxLength(maxLength:number):Function',
-  'Validators.minLength(minLength:number):Function',
-  'Validators.nullValidator(c:any):{[key:string]:boolean}',
-  'Validators.pattern(pattern:string):Function',
-  'Validators.required(control:Control):{[key:string]:boolean}',
+  'Validators.compose(validators:ValidatorFn[]):ValidatorFn',
+  'Validators.composeAsync(validators:AsyncValidatorFn[]):AsyncValidatorFn',
+  'Validators.maxLength(maxLength:number):ValidatorFn',
+  'Validators.minLength(minLength:number):ValidatorFn',
+  'Validators.nullValidator(c:AbstractControl):{[key:string]:boolean}',
+  'Validators.pattern(pattern:string):ValidatorFn',
+  'Validators.required(control:AbstractControl):{[key:string]:boolean}',
   'RadioButtonState',
   'RadioButtonState.constructor(checked:boolean, value:string)',
   'const COMMON_DIRECTIVES:Type[][]',