cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(docs-infra): fix method name (getPrfromBranch --> getPrFromBranch) (#25671)

Browse Source 
PR Close #25671
This commit is contained in:
George Kalpakas 2018-08-26 00:25:59 +03:00 committed by Kara Erickson
parent ce4aa5cb93
commit 153738dce9
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
aio/aio-builds-setup/dockerbuild/scripts-js/lib/preview-server/build-retriever.ts
View File

@ -34,7 +34,7 @@ export class BuildRetriever {
const buildInfo = await this.api.getBuildInfo(buildNum); const buildInfo = await this.api.getBuildInfo(buildNum);
const githubInfo: GithubInfo = { const githubInfo: GithubInfo = {
org: buildInfo.username, org: buildInfo.username,
pr: getPrfromBranch(buildInfo.branch), pr: getPrFromBranch(buildInfo.branch),
repo: buildInfo.reponame, repo: buildInfo.reponame,
sha: buildInfo.vcs_revision, sha: buildInfo.vcs_revision,
success: !buildInfo.failed, success: !buildInfo.failed,
@ -73,7 +73,7 @@ export class BuildRetriever {
} }
} }
function getPrfromBranch(branch: string): number { function getPrFromBranch(branch: string): number {
// CircleCI only exposes PR numbers via the `branch` field :-( // CircleCI only exposes PR numbers via the `branch` field :-(
const match = /^pull\/(\d+)$/.exec(branch); const match = /^pull\/(\d+)$/.exec(branch);
if (!match) { if (!match) {