build: review comments addressed (#26488)

PR Close #26488
2018-10-18 09:58:38 -07:00
parent 74ea4e9b5d
commit 15c2467dbd
25 changed files with 124 additions and 164 deletions
--- a/packages/core/test/bundling/animation_world/BUILD.bazel
+++ b/packages/core/test/bundling/animation_world/BUILD.bazel
@ -35,9 +35,6 @@ ng_rollup_bundle(
 js_expected_symbol_test(
    name = "symbol_test",
    src = ":bundle.min_debug.js",
-    data = [
-        "@ngdeps//typescript",
-    ],
    golden = ":bundle.golden_symbols.json",
    tags = [
        "ivy-local",
--- a/packages/core/test/bundling/hello_world/BUILD.bazel
+++ b/packages/core/test/bundling/hello_world/BUILD.bazel
@ -59,9 +59,6 @@ jasmine_node_test(
 js_expected_symbol_test(
    name = "symbol_test",
    src = ":bundle.min_debug.js",
-    data = [
-        "@ngdeps//typescript",
-    ],
    golden = ":bundle.golden_symbols.json",
    tags = [
        "ivy-local",
--- a/packages/core/test/bundling/hello_world_r2/BUILD.bazel
+++ b/packages/core/test/bundling/hello_world_r2/BUILD.bazel
@ -54,9 +54,6 @@ jasmine_node_test(
 js_expected_symbol_test(
    name = "symbol_test",
    src = ":bundle.min_debug.js",
-    data = [
-        "@ngdeps//typescript",
-    ],
    golden = ":bundle.golden_symbols.json",
 )

--- a/packages/core/test/bundling/injection/BUILD.bazel
+++ b/packages/core/test/bundling/injection/BUILD.bazel
@ -11,7 +11,6 @@ ts_library(
    ],
    deps = [
        "//packages/core",
-        "@ngdeps//typescript",
    ],
 )

@ -50,8 +49,5 @@ jasmine_node_test(
 js_expected_symbol_test(
    name = "symbol_test",
    src = ":bundle.min_debug.js",
-    data = [
-        "@ngdeps//typescript",
-    ],
    golden = ":bundle.golden_symbols.json",
 )
--- a/packages/core/test/bundling/todo/BUILD.bazel
+++ b/packages/core/test/bundling/todo/BUILD.bazel
@ -66,9 +66,6 @@ jasmine_node_test(
 js_expected_symbol_test(
    name = "symbol_test",
    src = ":bundle.min_debug.js",
-    data = [
-        "@ngdeps//typescript",
-    ],
    golden = ":bundle.golden_symbols.json",
    tags = [
        "ivy-local",
--- a/packages/core/test/bundling/todo_r2/BUILD.bazel
+++ b/packages/core/test/bundling/todo_r2/BUILD.bazel
@ -72,9 +72,6 @@ jasmine_node_test(
 js_expected_symbol_test(
    name = "symbol_test",
    src = ":bundle.min_debug.js",
-    data = [
-        "@ngdeps//typescript",
-    ],
    golden = ":bundle.golden_symbols.json",
    tags = [
        "ivy-local",