ci: move public-api goldens to goldens directory (#35768)

Moves the public api .d.ts files from tools/public_api_guard to
goldens/public-api.

Additionally, provides a README in the goldens directory and a script
assist in testing the current state of the repo against the goldens as
well as a command for accepting all changes to the goldens in a single
command.

PR Close #35768
This commit is contained in:
Joey Perrott
2020-02-26 09:09:35 -08:00
committed by Matias Niemelä
parent 19cfaf7f4c
commit 15f8afa4bf
62 changed files with 483 additions and 348 deletions

View File

@ -1,4 +1,4 @@
load("//tools:defaults.bzl", "ng_module", "ng_package")
load("//tools:defaults.bzl", "ng_module", "ng_package", "ts_api_guardian_test_npm_package")
package(default_visibility = ["//visibility:public"])
@ -39,3 +39,13 @@ ng_package(
"//packages/animations/browser/testing",
],
)
ts_api_guardian_test_npm_package(
name = "animations_api",
actualDir = "packages/animations/npm_package",
data = [
":npm_package",
"//goldens:public-api",
],
goldenDir = "goldens/public-api/animations",
)

View File

@ -1,4 +1,4 @@
load("//tools:defaults.bzl", "ng_module", "ng_package")
load("//tools:defaults.bzl", "ng_module", "ng_package", "ts_api_guardian_test_npm_package")
package(default_visibility = ["//visibility:public"])
@ -51,3 +51,13 @@ ng_package(
"//packages/common/upgrade",
],
)
ts_api_guardian_test_npm_package(
name = "common_api",
actualDir = "packages/common/npm_package",
data = [
":npm_package",
"//goldens:public-api",
],
goldenDir = "goldens/public-api/common",
)

View File

@ -1,6 +1,6 @@
package(default_visibility = ["//visibility:public"])
load("//tools:defaults.bzl", "pkg_npm", "ts_library")
load("//tools:defaults.bzl", "pkg_npm", "ts_api_guardian_test", "ts_library")
load("@npm_bazel_typescript//:index.bzl", "ts_config")
ts_config(
@ -59,3 +59,23 @@ pkg_npm(
"//packages/compiler-cli/ngcc",
],
)
ts_api_guardian_test(
name = "error_code_api",
actual = "packages/compiler-cli/npm_package/src/ngtsc/diagnostics/src/error_code.d.ts",
data = [
":npm_package",
"//goldens:public-api",
],
golden = "goldens/public-api/compiler-cli/error_code.d.ts",
)
ts_api_guardian_test(
name = "compiler_options_api",
actual = "packages/compiler-cli/npm_package/src/ngtsc/core/api/src/public_options.d.ts",
data = [
":npm_package",
"//goldens:public-api",
],
golden = "goldens/public-api/compiler-cli/compiler_options.d.ts",
)

View File

@ -1,4 +1,4 @@
load("//tools:defaults.bzl", "ng_module", "ng_package")
load("//tools:defaults.bzl", "ng_module", "ng_package", "ts_api_guardian_test", "ts_api_guardian_test_npm_package")
package(default_visibility = ["//visibility:public"])
@ -54,3 +54,23 @@ ng_package(
"//packages/core/testing",
],
)
ts_api_guardian_test_npm_package(
name = "core_api",
actualDir = "packages/core/npm_package",
data = [
":npm_package",
"//goldens:public-api",
],
goldenDir = "goldens/public-api/core",
)
ts_api_guardian_test(
name = "ng_global_utils_api",
actual = "packages/core/src/render3/global_utils_api.d.ts",
data = [
"//goldens:public-api",
"//packages/core",
],
golden = "goldens/public-api/core/global_utils.d.ts",
)

View File

@ -1,4 +1,4 @@
load("//tools:defaults.bzl", "ng_module", "ng_package")
load("//tools:defaults.bzl", "ng_module", "ng_package", "ts_api_guardian_test_npm_package")
package(default_visibility = ["//visibility:public"])
@ -37,3 +37,13 @@ ng_package(
":elements",
],
)
ts_api_guardian_test_npm_package(
name = "elements_api",
actualDir = "packages/elements/npm_package",
data = [
":npm_package",
"//goldens:public-api",
],
goldenDir = "goldens/public-api/elements",
)

View File

@ -1,4 +1,4 @@
load("//tools:defaults.bzl", "ng_module", "ng_package")
load("//tools:defaults.bzl", "ng_module", "ng_package", "ts_api_guardian_test_npm_package")
package(default_visibility = ["//visibility:public"])
@ -37,3 +37,13 @@ ng_package(
":forms",
],
)
ts_api_guardian_test_npm_package(
name = "forms_api",
actualDir = "packages/forms/npm_package",
data = [
":npm_package",
"//goldens:public-api",
],
goldenDir = "goldens/public-api/forms",
)

View File

@ -1,4 +1,4 @@
load("//tools:defaults.bzl", "ng_module", "ng_package")
load("//tools:defaults.bzl", "ng_module", "ng_package", "ts_api_guardian_test_npm_package")
package(default_visibility = ["//visibility:public"])
@ -42,3 +42,13 @@ ng_package(
"//packages/http/testing",
],
)
ts_api_guardian_test_npm_package(
name = "http_api",
actualDir = "packages/http/npm_package",
data = [
":npm_package",
"//goldens:public-api",
],
goldenDir = "goldens/public-api/http",
)

View File

@ -1,4 +1,4 @@
load("//tools:defaults.bzl", "ng_package", "ts_library")
load("//tools:defaults.bzl", "ng_package", "ts_api_guardian_test_npm_package", "ts_library")
package(default_visibility = ["//visibility:public"])
@ -36,3 +36,13 @@ ng_package(
"//packages/localize/init",
],
)
ts_api_guardian_test_npm_package(
name = "localize_api",
actualDir = "packages/localize/npm_package",
data = [
":npm_package",
"//goldens:public-api",
],
goldenDir = "goldens/public-api/localize",
)

View File

@ -1,4 +1,4 @@
load("//tools:defaults.bzl", "ng_module", "ng_package")
load("//tools:defaults.bzl", "ng_module", "ng_package", "ts_api_guardian_test_npm_package")
package(default_visibility = ["//visibility:public"])
@ -40,3 +40,13 @@ ng_package(
"//packages/platform-browser-dynamic/testing",
],
)
ts_api_guardian_test_npm_package(
name = "platform-browser-dynamic_api",
actualDir = "packages/platform-browser-dynamic/npm_package",
data = [
":npm_package",
"//goldens:public-api",
],
goldenDir = "goldens/public-api/platform-browser-dynamic",
)

View File

@ -1,4 +1,4 @@
load("//tools:defaults.bzl", "ng_module", "ng_package")
load("//tools:defaults.bzl", "ng_module", "ng_package", "ts_api_guardian_test_npm_package")
package(default_visibility = ["//visibility:public"])
@ -43,3 +43,13 @@ ng_package(
"//packages/platform-browser/testing",
],
)
ts_api_guardian_test_npm_package(
name = "platform-browser_api",
actualDir = "packages/platform-browser/npm_package",
data = [
":npm_package",
"//goldens:public-api",
],
goldenDir = "goldens/public-api/platform-browser",
)

View File

@ -1,4 +1,4 @@
load("//tools:defaults.bzl", "ng_module", "ng_package")
load("//tools:defaults.bzl", "ng_module", "ng_package", "ts_api_guardian_test_npm_package")
package(default_visibility = ["//visibility:public"])
@ -46,3 +46,13 @@ ng_package(
"//packages/platform-server/testing",
],
)
ts_api_guardian_test_npm_package(
name = "platform-server_api",
actualDir = "packages/platform-server/npm_package",
data = [
":npm_package",
"//goldens:public-api",
],
goldenDir = "goldens/public-api/platform-server",
)

View File

@ -1,4 +1,4 @@
load("//tools:defaults.bzl", "ng_module", "ng_package")
load("//tools:defaults.bzl", "ng_module", "ng_package", "ts_api_guardian_test_npm_package")
package(default_visibility = ["//visibility:public"])
@ -31,3 +31,13 @@ ng_package(
visibility = ["//integration:__pkg__"],
deps = [":platform-webworker-dynamic"],
)
ts_api_guardian_test_npm_package(
name = "platform-webworker-dynamic_api",
actualDir = "packages/platform-webworker-dynamic/npm_package",
data = [
":npm_package",
"//goldens:public-api",
],
goldenDir = "goldens/public-api/platform-webworker-dynamic",
)

View File

@ -1,4 +1,4 @@
load("//tools:defaults.bzl", "ng_module", "ng_package")
load("//tools:defaults.bzl", "ng_module", "ng_package", "ts_api_guardian_test_npm_package")
package(default_visibility = ["//visibility:public"])
@ -37,3 +37,13 @@ ng_package(
":platform-webworker",
],
)
ts_api_guardian_test_npm_package(
name = "platform-webworker_api",
actualDir = "packages/platform-webworker/npm_package",
data = [
":npm_package",
"//goldens:public-api",
],
goldenDir = "goldens/public-api/platform-webworker",
)

View File

@ -1,4 +1,4 @@
load("//tools:defaults.bzl", "ng_module", "ng_package")
load("//tools:defaults.bzl", "ng_module", "ng_package", "ts_api_guardian_test_npm_package")
package(default_visibility = ["//visibility:public"])
@ -43,3 +43,13 @@ ng_package(
"//packages/router/upgrade",
],
)
ts_api_guardian_test_npm_package(
name = "router_api",
actualDir = "packages/router/npm_package",
data = [
":npm_package",
"//goldens:public-api",
],
goldenDir = "goldens/public-api/router",
)

View File

@ -1,4 +1,4 @@
load("//tools:defaults.bzl", "ng_module", "ng_package")
load("//tools:defaults.bzl", "ng_module", "ng_package", "ts_api_guardian_test_npm_package")
package(default_visibility = ["//visibility:public"])
@ -58,3 +58,13 @@ ng_package(
"//packages/service-worker/config",
],
)
ts_api_guardian_test_npm_package(
name = "service-worker_api",
actualDir = "packages/service-worker/npm_package",
data = [
":npm_package",
"//goldens:public-api",
],
goldenDir = "goldens/public-api/service-worker",
)

View File

@ -1,4 +1,4 @@
load("//tools:defaults.bzl", "ng_module", "ng_package")
load("//tools:defaults.bzl", "ng_module", "ng_package", "ts_api_guardian_test_npm_package")
package(default_visibility = ["//visibility:public"])
@ -38,3 +38,13 @@ ng_package(
"//packages/upgrade/static/testing",
],
)
ts_api_guardian_test_npm_package(
name = "upgrade_api",
actualDir = "packages/upgrade/npm_package",
data = [
":npm_package",
"//goldens:public-api",
],
goldenDir = "goldens/public-api/upgrade",
)