cargdev/angular
1
0
Fork 0
Code Issues 5 Pull Requests Actions Packages Projects Releases Wiki Activity

feat: add support for typescript 3.2 (#27536)

Browse Source 
https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-2.html
https://blogs.msdn.microsoft.com/typescript/2018/11/29/announcing-typescript-3-2/

Any application using tsickle for closure compatibility will need to update it's tsickle
dependency to 0.34

PR Close #27536
This commit is contained in:
Igor Minar
2018-12-06 23:01:08 -08:00
committed by Miško Hevery
parent b04bc5d06c
commit 17e702bf8b
13 changed files with 200 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
packages/language-service/src/ts_plugin.ts
View File

@ -275,7 +275,7 @@ export function create(info: any /* ts.server.PluginCreateInfo */): ts.LanguageS
};
proxy.getDefinitionAtPosition = function(
fileName: string, position: number): ts.DefinitionInfo[] {
fileName: string, position: number): ReadonlyArray<ts.DefinitionInfo> {
let base = oldLS.getDefinitionAtPosition(fileName, position);
if (base && base.length) {
return base;
@ -283,10 +283,12 @@ export function create(info: any /* ts.server.PluginCreateInfo */): ts.LanguageS
return tryOperation('get definition', () => {
const ours = ls.getDefinitionAt(fileName, position);
let combined;
if (ours && ours.length) {
base = base || [];
combined = base && base.concat([]) || [];
for (const loc of ours) {
base.push({
combined.push({
fileName: loc.fileName,
textSpan: {start: loc.span.start, length: loc.span.end - loc.span.start},
name: '',
@ -296,8 +298,10 @@ export function create(info: any /* ts.server.PluginCreateInfo */): ts.LanguageS
containerKind: 'file' as any,
});
}
} else {
combined = base;
}
return base;
return combined;
}) || [];
};