cargdev/angular
1
0
Fork 0
Code Issues 17 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(router): properly compare array queryParams for equality (#37709) (#37860)

Browse Source 
queryParams will be judged different if the arrays do not contain the same frequency of elements and the same otherwise.

PR Close #37860
This commit is contained in:
Ruben Schuckit
2020-06-30 17:08:32 -04:00
committed by Alex Rickabaugh
parent a5c30733cb
commit 1801d0c650
3 changed files with 23 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
packages/router/test/url_tree.spec.ts
View File

@ -67,6 +67,24 @@ describe('UrlTree', () => {
expect(containsTree(t1, t2, true)).toBe(false);
});
it('should return false when queryParams are not the same', () => {
const t1 = serializer.parse('/one/two?test=4&test=4&test=2');
const t2 = serializer.parse('/one/two?test=4&test=3&test=2');
expect(containsTree(t1, t2, false)).toBe(false);
});
it('should return true when queryParams are the same in different order', () => {
const t1 = serializer.parse('/one/two?test=4&test=3&test=2');
const t2 = serializer.parse('/one/two?test=2&test=3&test=4');
expect(containsTree(t1, t2, false)).toBe(true);
});
it('should return true when queryParams are the same in different order', () => {
const t1 = serializer.parse('/one/two?test=4&test=4&test=1');
const t2 = serializer.parse('/one/two?test=1&test=4&test=4');
expect(containsTree(t1, t2, false)).toBe(true);
});
it('should return false when containee is missing queryParams', () => {
const t1 = serializer.parse('/one/two?page=5');
const t2 = serializer.parse('/one/two');