cargdev/angular
1
0
Fork 0
Code Issues 6 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(zone.js): patch nodejs EventEmtter.prototype.off (#37863)

Browse Source 
Close #35473

zone.js nodejs patch should also patch `EventEmitter.prototype.off` as `removeListener`.
So `off` can correctly remove the listeners added by `EventEmitter.prototype.addListener`

PR Close #37863
This commit is contained in:
JiaLiPassion
2020-07-01 07:15:22 +09:00
committed by Misko Hevery
parent a71f114ba4
commit 1822cbcd46
2 changed files with 14 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
packages/zone.js/test/node/events.spec.ts
View File

@ -66,6 +66,18 @@ describe('nodejs EventEmitter', () => {
emitter.emit('test2', 'test value');
});
});
it('should remove listeners by calling off properly', () => {
zoneA.run(() => {
emitter.on('test', shouldNotRun);
emitter.on('test2', shouldNotRun);
emitter.off('test', shouldNotRun);
});
zoneB.run(() => {
emitter.off('test2', shouldNotRun);
emitter.emit('test', 'test value');
emitter.emit('test2', 'test value');
});
});
it('remove listener should return event emitter', () => {
zoneA.run(() => {
emitter.on('test', shouldNotRun);