From 183f27894c77c7939c1a6ebe55f49294e513897f Mon Sep 17 00:00:00 2001 From: Keen Yee Liau Date: Mon, 17 Dec 2018 13:17:13 -0800 Subject: [PATCH] fix(bazel): Set module_name and enable ng test (#27715) Relative imports in Typescript files only work when module_name is defined in ts_library (when run in Node.js). See issue https://github.com/bazelbuild/rules_typescript/issues/360 With that fixed, `ng test` now works. `ng build` requires `node_modules` to be available in the project directory, so it's not usable yet. Running `yarn` in project directory does not work because of postinstall version check. PR Close #27715 --- packages/bazel/src/builders/BUILD.bazel | 1 + .../bazel-workspace/files/e2e/BUILD.bazel.template | 5 ++++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/bazel/src/builders/BUILD.bazel b/packages/bazel/src/builders/BUILD.bazel index 0a4c2299d0..c745a5816b 100644 --- a/packages/bazel/src/builders/BUILD.bazel +++ b/packages/bazel/src/builders/BUILD.bazel @@ -20,6 +20,7 @@ ts_library( data = [ "schema.json", ], + module_name = "@angular/bazel/src/builders", deps = [ "@ngdeps//@angular-devkit/architect", "@ngdeps//@angular-devkit/core", diff --git a/packages/bazel/src/schematics/bazel-workspace/files/e2e/BUILD.bazel.template b/packages/bazel/src/schematics/bazel-workspace/files/e2e/BUILD.bazel.template index 3006b04ae5..25995db21e 100644 --- a/packages/bazel/src/schematics/bazel-workspace/files/e2e/BUILD.bazel.template +++ b/packages/bazel/src/schematics/bazel-workspace/files/e2e/BUILD.bazel.template @@ -12,7 +12,10 @@ ts_library( "@npm//@types/node", "@npm//jasmine", "@npm//protractor", - ] + ], + data = [ + "//:tsconfig.json", + ], ) protractor_web_test_suite(