From 1a0cb215380dd24c8e47dff351d21911022b8835 Mon Sep 17 00:00:00 2001 From: Kara Erickson Date: Sat, 17 Mar 2018 11:52:05 -0700 Subject: [PATCH] refactor(ivy): remove unnecessary binding from hello world (#22848) PR Close #22848 --- .../hello_world/bundle.golden_symbols.json | 36 ------------------- .../core/test/bundling/hello_world/index.ts | 7 ++-- 2 files changed, 2 insertions(+), 41 deletions(-) diff --git a/packages/core/test/bundling/hello_world/bundle.golden_symbols.json b/packages/core/test/bundling/hello_world/bundle.golden_symbols.json index e46681f06a..8c015f9491 100644 --- a/packages/core/test/bundling/hello_world/bundle.golden_symbols.json +++ b/packages/core/test/bundling/hello_world/bundle.golden_symbols.json @@ -14,9 +14,6 @@ { "name": "NG_PROJECT_AS_ATTR_NAME" }, - { - "name": "NO_CHANGE" - }, { "name": "Symbol$1" }, @@ -44,9 +41,6 @@ { "name": "baseDirectiveCreate" }, - { - "name": "bindingUpdated" - }, { "name": "callHooks" }, @@ -92,21 +86,9 @@ { "name": "executeInitHooks" }, - { - "name": "findFirstRNode" - }, - { - "name": "findNextRNodeSibling" - }, { "name": "getDirectiveInstance" }, - { - "name": "getNextLNodeWithProjection" - }, - { - "name": "getNextOrParentSiblingNode" - }, { "name": "getOrCreateTView" }, @@ -116,24 +98,12 @@ { "name": "hostElement" }, - { - "name": "initBindings" - }, { "name": "initChangeDetectorIfExisting" }, - { - "name": "insertChild" - }, - { - "name": "interpolation1" - }, { "name": "invertObject" }, - { - "name": "isDifferent" - }, { "name": "isProceduralRenderer" }, @@ -185,12 +155,6 @@ { "name": "text" }, - { - "name": "textBinding" - }, - { - "name": "throwErrorIfNoChangesMode" - }, { "name": "viewAttached" } diff --git a/packages/core/test/bundling/hello_world/index.ts b/packages/core/test/bundling/hello_world/index.ts index c8a55b2a80..2f78d6e00b 100644 --- a/packages/core/test/bundling/hello_world/index.ts +++ b/packages/core/test/bundling/hello_world/index.ts @@ -6,20 +6,17 @@ * found in the LICENSE file at https://angular.io/license */ -import {ɵT as T, ɵdefineComponent as defineComponent, ɵi1 as i1, ɵrenderComponent as renderComponent, ɵt as t} from '@angular/core'; +import {ɵT as T, ɵdefineComponent as defineComponent, ɵrenderComponent as renderComponent} from '@angular/core'; class HelloWorld { - name = 'World'; - static ngComponentDef = defineComponent({ type: HelloWorld, tag: 'hello-world', factory: () => new HelloWorld(), template: function HelloWorldTemplate(ctx: HelloWorld, cm: boolean) { if (cm) { - T(0); + T(0, 'Hello World!'); } - t(0, i1('Hello ', ctx.name, '!')); } }); }