cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(compiler): also create .ngfactory.js files in non obvious cases (#19301)

Browse Source 
E.g. when an exported class contains a ctor argument which is
from another compilation unit.

PR Close #19301
This commit is contained in:
Tobias Bosch
2017-09-20 16:31:02 -07:00
committed by Igor Minar
parent c76da27240
commit 1a647c399b
2 changed files with 29 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
packages/compiler-cli/test/ngc_spec.ts
View File

@ -840,6 +840,7 @@ describe('ngc transformer command-line', () => {
})
export class Module {}
`);
write('lib1/class1.ts', `export class Class1 {}`);
// Lib 2
write('lib2/tsconfig-lib2.json', `{
@ -855,6 +856,13 @@ describe('ngc transformer command-line', () => {
write('lib2/module.ts', `
export {Module} from 'lib1_built/module';
`);
write('lib2/class2.ts', `
import {Class1} from 'lib1_built/class1';
export class Class2 {
constructor(class1: Class1) {}
}
`);
// Application
write('app/tsconfig-app.json', `{
@ -904,6 +912,12 @@ describe('ngc transformer command-line', () => {
shouldExist('lib2_built/module.ngfactory.js');
shouldExist('lib2_built/module.ngfactory.d.ts');
shouldExist('lib2_built/class2.ngsummary.json');
shouldNotExist('lib2_built/class2.ngsummary.js');
shouldNotExist('lib2_built/class2.ngsummary.d.ts');
shouldExist('lib2_built/class2.ngfactory.js');
shouldExist('lib2_built/class2.ngfactory.d.ts');
// app
// make `shouldExist` / `shouldNotExist` relative to `built`
outDir = path.resolve(basePath, 'built');