cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(language-service): Function alias should be callable (#33782)

Browse Source 
This commit fixes a long standing bug whereby a template variable that
gets initialized to a class method gets resolved to the Any type, thus
when it is called the language service produces error "Member X is not
callable".

PR closes https://github.com/angular/angular/issues/16643
PR closes https://github.com/angular/vscode-ng-language-service/issues/234

PR Close #33782
This commit is contained in:
Keen Yee Liau
2019-11-12 17:40:56 -08:00
committed by Alex Rickabaugh
parent ab0bcee144
commit 1d3aae6f92
2 changed files with 12 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
packages/language-service/test/diagnostics_spec.ts
View File

@ -109,6 +109,16 @@ describe('diagnostics', () => {
.toBe(`Identifier 'age' is not defined. 'Hero' does not contain such a member`);
});
it('should not report error for variable initialized as class method', () => {
mockHost.override(TEST_TEMPLATE, `
<ng-template let-greet="myClick">
<span (click)="greet()"></span>
</ng-template>
`);
const diagnostics = ngLS.getDiagnostics(TEST_TEMPLATE);
expect(diagnostics).toEqual([]);
});
describe('in expression-cases.ts', () => {
it('should report access to an unknown field', () => {
const diags = ngLS.getDiagnostics(EXPRESSION_CASES).map(d => d.messageText);