From 1ed353104931edb585e06e16da66c0be1bed49d8 Mon Sep 17 00:00:00 2001 From: ayazhafiz Date: Sun, 1 Sep 2019 09:58:14 -0500 Subject: [PATCH] fix(language-service): re-add regressed templateUrl tests (#32438) Commit 18ce58 (per #32378) regressed tests for templateUrl definitions. This PR re-adds those tests. PR Close #32438 --- .../language-service/test/definitions_spec.ts | 22 +++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/packages/language-service/test/definitions_spec.ts b/packages/language-service/test/definitions_spec.ts index ba34e5254d..b6849140bd 100644 --- a/packages/language-service/test/definitions_spec.ts +++ b/packages/language-service/test/definitions_spec.ts @@ -253,4 +253,26 @@ describe('definitions', () => { // Not asserting the textSpan of definition because it's external file } }); + + it('should be able to find a template from a url', () => { + const fileName = mockHost.addCode(` + @Component({ + templateUrl: './«test».ng', + }) + export class MyComponent {}`); + + const marker = mockHost.getReferenceMarkerFor(fileName, 'test'); + const result = ngService.getDefinitionAt(fileName, marker.start); + + expect(result).toBeDefined(); + const {textSpan, definitions} = result !; + + expect(textSpan).toEqual({start: marker.start - 2, length: 9}); + + expect(definitions).toBeDefined(); + expect(definitions !.length).toBe(1); + const [def] = definitions !; + expect(def.fileName).toBe('/app/test.ng'); + expect(def.textSpan).toEqual({start: 0, length: 0}); + }); });