cargdev/angular
1
0
Fork 0
Code Issues 9 Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(core): move usage detection into usage strategy (#29815)

Browse Source 
In order to support multiple strategies for detecting the query timing, the
query usage logic has been moved into a query usage strategy.

PR Close #29815
This commit is contained in:
Paul Gschwendtner
2019-04-08 19:37:31 +02:00
committed by Alex Rickabaugh
parent 7a7781e925
commit 205a45e9a8
8 changed files with 96 additions and 59 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
packages/core/schematics/migrations/static-queries/google3/explicitQueryTimingRule.ts
View File

@ -11,9 +11,9 @@ import * as ts from 'typescript';
import {NgComponentTemplateVisitor} from '../../../utils/ng_component_template';
import {visitAllNodes} from '../../../utils/typescript/visit_nodes';
import {analyzeNgQueryUsage} from '../angular/analyze_query_usage';
import {NgQueryResolveVisitor} from '../angular/ng_query_visitor';
import {QueryTiming} from '../angular/query-definition';
import {QueryUsageStrategy} from '../strategies/usage_strategy/usage_strategy';
import {getTransformedQueryCallExpr} from '../transform';
const FAILURE_MESSAGE = 'Query does not explicitly specify its timing. Read more here: ' +
@ -52,6 +52,7 @@ export class Rule extends Rules.TypedRule {
});
const queries = resolvedQueries.get(sourceFile);
const usageStrategy = new QueryUsageStrategy(classMetadata, typeChecker);
// No queries detected for the given source file.
if (!queries) {
@ -62,7 +63,7 @@ export class Rule extends Rules.TypedRule {
// query definitions to explicitly declare the query timing (static or dynamic)
queries.forEach(q => {
const queryExpr = q.decorator.node.expression;
const timing = analyzeNgQueryUsage(q, classMetadata, typeChecker);
const timing = usageStrategy.detectTiming(q);
const transformedNode = getTransformedQueryCallExpr(q, timing);
if (!transformedNode) {