cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

build: make commit validation accept typical Revert messages (#23480)

Browse Source 
fixes #23479

PR Close #23480
This commit is contained in:
Victor Berchet
2018-04-20 18:03:41 -07:00
parent b9431e88fb
commit 212b806eda
2 changed files with 25 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
tools/validate-commit-message/validate-commit-message.js
View File

@ -22,18 +22,21 @@ const configPath = path.resolve(__dirname, './commit-message.json');
const config = JSON.parse(fs.readFileSync(configPath, 'utf8'));
const PATTERN = /^(\w+)(?:\(([^)]+)\))?\: (.+)$/;
const FIXUP_SQUASH = /^(fixup|squash)\! /i;
const REVERT = /^revert:? (\"(.*)\"|(.*))?$/i;
const REVERT = /^revert:? /i;
module.exports = function(commitSubject) {
commitSubject = commitSubject.replace(FIXUP_SQUASH, '');
commitSubject = commitSubject.replace(REVERT, function(m, g1, g2, g3) { return g2 || g3; });
const subject = commitSubject.replace(FIXUP_SQUASH, '');
if (commitSubject.length > config['maxLength']) {
if (subject.match(REVERT)) {
return true;
}
if (subject.length > config['maxLength']) {
error(`The commit message is longer than ${config['maxLength']} characters`, commitSubject);
return false;
}
const match = PATTERN.exec(commitSubject);
const match = PATTERN.exec(subject);
if (!match) {
error(
`The commit message does not match the format of '<type>(<scope>): <subject>' OR 'Revert: "type(<scope>): <subject>"'`,