From 21e566d9bca514296d1755c529ee7c97064cb36e Mon Sep 17 00:00:00 2001 From: Alan Agius Date: Thu, 13 Sep 2018 10:54:53 +0200 Subject: [PATCH] build: use nodejs public api (#25940) `nodejs_binary` and `nodejs_test` from `@build_bazel_rules_nodejs//:defs.bzl` and `@build_bazel_rules_nodejs//internal/node:node.bzl` are different as the first one uses a macro https://github.com/bazelbuild/rules_nodejs/blob/master/internal/node/node.bzl#L229 to wrap the `nodejs_binary` and `nodejs_test` as an `.exe` for Windows. PR Close #25940 --- tools/ts-api-guardian/index.bzl | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tools/ts-api-guardian/index.bzl b/tools/ts-api-guardian/index.bzl index dc7868914d..8632e97935 100644 --- a/tools/ts-api-guardian/index.bzl +++ b/tools/ts-api-guardian/index.bzl @@ -15,7 +15,7 @@ """Runs ts_api_guardian """ -load("@build_bazel_rules_nodejs//internal/node:node.bzl", "nodejs_binary", "nodejs_test") +load("@build_bazel_rules_nodejs//:defs.bzl", "nodejs_binary", "nodejs_test") COMMON_MODULE_IDENTIFIERS = ["angular", "jasmine", "protractor"] @@ -25,7 +25,6 @@ def ts_api_guardian_test(name, golden, actual, data = [], strip_export_pattern = data += [ "@angular//tools/ts-api-guardian:lib", "@angular//tools/ts-api-guardian:bin/ts-api-guardian", - "@bazel_tools//tools/bash/runfiles", ] args = [ @@ -44,7 +43,6 @@ def ts_api_guardian_test(name, golden, actual, data = [], strip_export_pattern = node_modules = "@ts-api-guardian_runtime_deps//:node_modules", entry_point = "angular/tools/ts-api-guardian/bin/ts-api-guardian", templated_args = args + ["--verify", golden, actual], - testonly = 1, **kwargs )