From 2486db7c2b2dec91152e47b9f14d8a89d1fbb935 Mon Sep 17 00:00:00 2001 From: Pete Bacon Darwin Date: Tue, 12 May 2020 08:20:01 +0100 Subject: [PATCH] docs(ngcc): tidy up typos etc in comments (#36989) This file had a few small typos and other issues that have now been fixed in this commit............................. PR Close #36989 --- .../ngcc/src/host/commonjs_umd_utils.ts | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/packages/compiler-cli/ngcc/src/host/commonjs_umd_utils.ts b/packages/compiler-cli/ngcc/src/host/commonjs_umd_utils.ts index 276bbbbce6..52fe529f9a 100644 --- a/packages/compiler-cli/ngcc/src/host/commonjs_umd_utils.ts +++ b/packages/compiler-cli/ngcc/src/host/commonjs_umd_utils.ts @@ -25,9 +25,11 @@ export interface ExportStatement extends ts.ExpressionStatement { } /** - * A CommonJS or UMD re-export statement. + * A CommonJS or UMD wildcard re-export statement. * - * In CommonJS/UMD, re-export statements can have several forms (depending, for example, on whether + * The CommonJS or UMD version of `export * from 'blah';`. + * + * These statements can have several forms (depending, for example, on whether * the TypeScript helpers are imported or emitted inline). The expression can have one of the * following forms: * - `__export(firstArg)` @@ -35,7 +37,7 @@ export interface ExportStatement extends ts.ExpressionStatement { * - `tslib.__export(firstArg, exports)` * - `tslib.__exportStar(firstArg, exports)` * - * In all cases, we only care about `firstApp`, which is the first argument of the re-export call + * In all cases, we only care about `firstArg`, which is the first argument of the re-export call * expression and can be either a `require('...')` call or an identifier (initialized via a * `require('...')` call). */ @@ -76,7 +78,7 @@ export function findRequireCallReference(id: ts.Identifier, checker: ts.TypeChec /** * Check whether the specified `ts.Statement` is an export statement, i.e. an expression statement - * of the form: `export. = ` + * of the form: `exports. = ` */ export function isExportStatement(stmt: ts.Statement): stmt is ExportStatement { return ts.isExpressionStatement(stmt) && ts.isBinaryExpression(stmt.expression) && @@ -87,8 +89,8 @@ export function isExportStatement(stmt: ts.Statement): stmt is ExportStatement { } /** - * Check whether the specified `ts.Statement` is a re-export statement, i.e. an expression statement - * of one of the following forms: + * Check whether the specified `ts.Statement` is a wildcard re-export statement. + * I.E. an expression statement of one of the following forms: * - `__export()` * - `__exportStar()` * - `tslib.__export(, exports)`