cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(bazel): add missing comment about JS providers to ng_module.bzl (#33332)

Browse Source 
PR Close #33332
This commit is contained in:
Greg Magolan 2019-10-22 13:49:12 -07:00 committed by Andrew Kushnir
parent f76b370d70
commit 25ed82db23
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
packages/bazel/src/ng_module.bzl
View File

@ -619,6 +619,8 @@ def _ng_module_impl(ctx):
ts_providers = ng_module_impl(ctx, compile_ts) ts_providers = ng_module_impl(ctx, compile_ts)
# Add in new JS providers # Add in new JS providers
# See design doc https://docs.google.com/document/d/1ggkY5RqUkVL4aQLYm7esRW978LgX3GUCnQirrk5E1C0/edit#
# and issue https://github.com/bazelbuild/rules_nodejs/issues/57 for more details.
ts_providers["providers"].extend([ ts_providers["providers"].extend([
js_named_module_info( js_named_module_info(
sources = ts_providers["typescript"]["es5_sources"], sources = ts_providers["typescript"]["es5_sources"],
@ -628,6 +630,9 @@ def _ng_module_impl(ctx):
sources = ts_providers["typescript"]["es6_sources"], sources = ts_providers["typescript"]["es6_sources"],
deps = ctx.attr.deps, deps = ctx.attr.deps,
), ),
# TODO: Add remaining shared JS providers from design doc
# (JSModuleInfo) and remove legacy "typescript" provider
# once it is no longer needed.
]) ])
return ts_providers_dict_to_struct(ts_providers) return ts_providers_dict_to_struct(ts_providers)