From 26516045e7d0be679b07fa1aa8c38ed60945d0d8 Mon Sep 17 00:00:00 2001 From: Pete Bacon Darwin Date: Mon, 30 Jul 2018 15:35:03 +0100 Subject: [PATCH] refactor(animations): do not use short parameter names (#25198) PR Close #25198 --- packages/animations/src/players/animation_player.ts | 4 ++-- tools/public_api_guard/animations/animations.d.ts | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/animations/src/players/animation_player.ts b/packages/animations/src/players/animation_player.ts index 32f5526b56..f3c73015ff 100644 --- a/packages/animations/src/players/animation_player.ts +++ b/packages/animations/src/players/animation_player.ts @@ -26,7 +26,7 @@ export interface AnimationPlayer { finish(): void; destroy(): void; reset(): void; - setPosition(p: any /** TODO #9100 */): void; + setPosition(position: any /** TODO #9100 */): void; getPosition(): number; parentPlayer: AnimationPlayer|null; readonly totalTime: number; @@ -93,7 +93,7 @@ export class NoopAnimationPlayer implements AnimationPlayer { } } reset(): void {} - setPosition(p: number): void {} + setPosition(position: number): void {} getPosition(): number { return 0; } /** @internal */ diff --git a/tools/public_api_guard/animations/animations.d.ts b/tools/public_api_guard/animations/animations.d.ts index 8835462f46..3b99955968 100644 --- a/tools/public_api_guard/animations/animations.d.ts +++ b/tools/public_api_guard/animations/animations.d.ts @@ -102,7 +102,7 @@ export interface AnimationPlayer { play(): void; reset(): void; restart(): void; - setPosition(p: any /** TODO #9100 */): void; + setPosition(position: any /** TODO #9100 */): void; } export interface AnimationQueryMetadata extends AnimationMetadata { @@ -191,7 +191,7 @@ export declare class NoopAnimationPlayer implements AnimationPlayer { play(): void; reset(): void; restart(): void; - setPosition(p: number): void; + setPosition(position: number): void; } export declare function query(selector: string, animation: AnimationMetadata | AnimationMetadata[], options?: AnimationQueryOptions | null): AnimationQueryMetadata;