cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "build: fix build failures with worker mode cache and @types/events (#31019)" (#31267)

Browse Source 
This reverts commit 6ba42f1da4a5e8abf87e3c4202d423504357fe49.

Reason: this causes failures in g3 with i18n extraction. See #31267.

PR Close #31267
This commit is contained in:
Alex Rickabaugh 2019-06-25 13:11:49 -07:00 committed by Kara Erickson
parent 98685e6f85
commit 26a85a82ff
4 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
packages/compiler-cli/BUILD.bazel
View File

@ -43,8 +43,7 @@ ts_library(
"//packages/compiler-cli/src/ngtsc/typecheck", "//packages/compiler-cli/src/ngtsc/typecheck",
"//packages/compiler-cli/src/ngtsc/util", "//packages/compiler-cli/src/ngtsc/util",
"@npm//@bazel/typescript", "@npm//@bazel/typescript",
"@npm//@types/chokidar", "@npm//@types",
"@npm//@types/node",
"@npm//reflect-metadata", "@npm//reflect-metadata",
"@npm//tsickle", "@npm//tsickle",
"@npm//typescript", "@npm//typescript",

1
packages/compiler-cli/integrationtest/bazel/ng_module/BUILD.bazel
View File

@ -20,6 +20,7 @@ ng_module(
], ],
deps = [ deps = [
"//packages/core", "//packages/core",
"@npm//@types",
"@npm//tslib", "@npm//tslib",
], ],
) )

2
packages/zone.js/test/BUILD.bazel
View File

@ -171,7 +171,7 @@ ts_library(
testonly = True, testonly = True,
srcs = ["npm_package/npm_package.spec.ts"], srcs = ["npm_package/npm_package.spec.ts"],
deps = [ deps = [
"@npm//@types/shelljs", "@npm//@types",
], ],
) )

2
tools/defaults.bzl
View File

@ -83,7 +83,6 @@ def ts_library(tsconfig = None, testonly = False, deps = [], module_name = None,
# Match the types[] in //packages:tsconfig-test.json # Match the types[] in //packages:tsconfig-test.json
deps.append("@npm//@types/jasmine") deps.append("@npm//@types/jasmine")
deps.append("@npm//@types/node") deps.append("@npm//@types/node")
deps.append("@npm//@types/events")
if not tsconfig and testonly: if not tsconfig and testonly:
tsconfig = _DEFAULT_TSCONFIG_TEST tsconfig = _DEFAULT_TSCONFIG_TEST
@ -105,7 +104,6 @@ def ng_module(name, tsconfig = None, entry_point = None, testonly = False, deps
# Match the types[] in //packages:tsconfig-test.json # Match the types[] in //packages:tsconfig-test.json
deps.append("@npm//@types/jasmine") deps.append("@npm//@types/jasmine")
deps.append("@npm//@types/node") deps.append("@npm//@types/node")
deps.append("@npm//@types/events")
if not tsconfig and testonly: if not tsconfig and testonly:
tsconfig = _DEFAULT_TSCONFIG_TEST tsconfig = _DEFAULT_TSCONFIG_TEST