cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

tests(ProtoViewBuilder): host properties binding to unknown props

Browse Source 
When binding a host property, we shouldn't try to bind to any
directive properties that might exist on a host element

Closes #3383
This commit is contained in:
Pawel Kozlowski 2015-07-30 11:46:52 +02:00 committed by Tobias Bosch
parent f8fa47e939
commit 2768158eaf
2 changed files with 19 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
modules/angular2/src/render/dom/view/proto_view_builder.ts
View File

@ -93,7 +93,7 @@ export class ProtoViewBuilder {
propertyBindings: dbb.propertyBindings, propertyBindings: dbb.propertyBindings,
eventBindings: dbb.eventBindings, eventBindings: dbb.eventBindings,
hostPropertyBindings: buildElementPropertyBindings(schemaRegistry, ebb.element, true, hostPropertyBindings: buildElementPropertyBindings(schemaRegistry, ebb.element, true,
dbb.hostPropertyBindings, new Set()) dbb.hostPropertyBindings, null)
}); });
}); });
var nestedProtoView = var nestedProtoView =
@ -336,9 +336,15 @@ function buildElementPropertyBindings(
if (isValidElementPropertyBinding(schemaRegistry, protoElement, isNgComponent, if (isValidElementPropertyBinding(schemaRegistry, protoElement, isNgComponent,
propertyBinding)) { propertyBinding)) {
propertyBindings.push(propertyBinding); propertyBindings.push(propertyBinding);
} else if (!SetWrapper.has(directiveTempaltePropertyNames, propertyNameInTemplate)) { } else if (!isPresent(directiveTempaltePropertyNames) ||
throw new BaseException( !SetWrapper.has(directiveTempaltePropertyNames, propertyNameInTemplate)) {
`Can't bind to '${propertyNameInTemplate}' since it isn't a known property of the '<${DOM.tagName(protoElement).toLowerCase()}>' element and there are no matching directives with a corresponding property`); // directiveTempaltePropertyNames is null for host property bindings
var exMsg =
`Can't bind to '${propertyNameInTemplate}' since it isn't a known property of the '<${DOM.tagName(protoElement).toLowerCase()}>' element`;
if (isPresent(directiveTempaltePropertyNames)) {
exMsg += ' and there are no matching directives with a corresponding property';
}
throw new BaseException(exMsg);
} }
}); });
return propertyBindings; return propertyBindings;

9
modules/angular2/test/render/dom/view/proto_view_builder_spec.ts
View File

@ -44,6 +44,15 @@ export function main() {
expect(() => builder.build(new DomElementSchemaRegistry())).not.toThrow(); expect(() => builder.build(new DomElementSchemaRegistry())).not.toThrow();
}); });
it('should throw for unknown host properties even if another directive uses it', () => {
var binder = builder.bindElement(el('<div/>'));
binder.bindDirective(0).bindProperty('someDirProperty', emptyExpr(), 'someDirProperty');
binder.bindDirective(1).bindHostProperty('someDirProperty', emptyExpr());
expect(() => builder.build(new DomElementSchemaRegistry()))
.toThrowError(
`Can't bind to 'someDirProperty' since it isn't a known property of the '<div>' element`);
});
it('should allow unknown properties on custom elements', () => { it('should allow unknown properties on custom elements', () => {
var binder = builder.bindElement(el('<some-custom/>')); var binder = builder.bindElement(el('<some-custom/>'));
binder.bindProperty('unknownProperty', emptyExpr()); binder.bindProperty('unknownProperty', emptyExpr());