cargdev/angular
1
0
Fork 0
Code Issues 17 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(compiler): update compiler to generate new slot allocations (#25607)

Browse Source 
PR Close #25607
This commit is contained in:
Kara Erickson
2018-08-21 18:52:26 -07:00
committed by Matias Niemelä
parent 5c95b4b3a3
commit 27e2039630
9 changed files with 62 additions and 52 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/core/src/render3/index.ts
View File

@ -76,8 +76,6 @@ export {
reference,
reserveSlots,
embeddedViewStart,
embeddedViewEnd,
detectChanges,

3
packages/core/src/render3/instructions.ts
View File

@ -2559,9 +2559,6 @@ export function bind<T>(value: T): T|NO_CHANGE {
return bindingUpdated(viewData[BINDING_INDEX]++, value) ? value : NO_CHANGE;
}
// TODO(kara): Remove this when updating the compiler (cannot remove without breaking JIT test)
export function reserveSlots(numSlots: number) {}
/**
* Create interpolation bindings with a variable number of expressions.
*

1
packages/core/src/render3/jit/environment.ts
View File

@ -90,7 +90,6 @@ export const angularCoreEnv: {[name: string]: Function} = {
'ɵquery': r3.query,
'ɵqueryRefresh': r3.queryRefresh,
'ɵregisterContentQuery': r3.registerContentQuery,
'ɵreserveSlots': r3.reserveSlots,
'ɵreference': r3.reference,
'ɵelementStyling': r3.elementStyling,
'ɵelementStylingMap': r3.elementStylingMap,

10
packages/core/src/render3/pipe.ts
View File

@ -68,7 +68,7 @@ function getPipeDef(name: string, registry: PipeDefList | null): PipeDefInternal
* the pipe only when an input to the pipe changes.
*
* @param index Pipe index where the pipe was stored on creation.
* @param slotOffset the offset in the reserved slot space {@link reserveSlots}
* @param slotOffset the offset in the reserved slot space
* @param v1 1st argument to {@link PipeTransform#transform}.
*/
export function pipeBind1(index: number, slotOffset: number, v1: any): any {
@ -84,7 +84,7 @@ export function pipeBind1(index: number, slotOffset: number, v1: any): any {
* the pipe only when an input to the pipe changes.
*
* @param index Pipe index where the pipe was stored on creation.
* @param slotOffset the offset in the reserved slot space {@link reserveSlots}
* @param slotOffset the offset in the reserved slot space
* @param v1 1st argument to {@link PipeTransform#transform}.
* @param v2 2nd argument to {@link PipeTransform#transform}.
*/
@ -101,7 +101,7 @@ export function pipeBind2(index: number, slotOffset: number, v1: any, v2: any):
* the pipe only when an input to the pipe changes.
*
* @param index Pipe index where the pipe was stored on creation.
* @param slotOffset the offset in the reserved slot space {@link reserveSlots}
* @param slotOffset the offset in the reserved slot space
* @param v1 1st argument to {@link PipeTransform#transform}.
* @param v2 2nd argument to {@link PipeTransform#transform}.
* @param v3 4rd argument to {@link PipeTransform#transform}.
@ -120,7 +120,7 @@ export function pipeBind3(index: number, slotOffset: number, v1: any, v2: any, v
* the pipe only when an input to the pipe changes.
*
* @param index Pipe index where the pipe was stored on creation.
* @param slotOffset the offset in the reserved slot space {@link reserveSlots}
* @param slotOffset the offset in the reserved slot space
* @param v1 1st argument to {@link PipeTransform#transform}.
* @param v2 2nd argument to {@link PipeTransform#transform}.
* @param v3 3rd argument to {@link PipeTransform#transform}.
@ -141,7 +141,7 @@ export function pipeBind4(
* the pipe only when an input to the pipe changes.
*
* @param index Pipe index where the pipe was stored on creation.
* @param slotOffset the offset in the reserved slot space {@link reserveSlots}
* @param slotOffset the offset in the reserved slot space
* @param values Array of arguments to pass to {@link PipeTransform#transform} method.
*/
export function pipeBindV(index: number, slotOffset: number, values: any[]): any {